17241 feature enhance trello create checklist item #17348
Conversation
- Bump package version for @pipedream/trello to 1.1.0. - Update action versions to 1.0.1 for 'Add Attachment To Card' and 1.0.1 for 'Create Card'. - Increment action versions for 'Add Checklist', 'Add Comment', 'Add Existing Label to Card', 'Add Member to Card', 'Archive Card', 'Complete Checklist Item', 'Create Checklist Item', 'Create Label', 'Create List', 'Delete Checklist', 'Find Labels', 'Find List', 'Get Card', 'Get List', 'Move Card to List', 'Remove Label from Card', 'Rename List', 'Search Boards', 'Search Cards', 'Search Checklists', 'Search Members', 'Update Card' to 0.2.2 or 0.3.0 as appropriate. - Introduce new due date and reminder options in 'Create Checklist Item'. - Update constants to include due reminder options. - Update source versions to 0.1.2 for various sources including 'Card Archived', 'Card Due Date Reminder', 'Card Moved', and others.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update primarily increments version numbers across multiple Trello action and source modules. Additionally, it introduces enhancements to the "Create Checklist Item" action, allowing due dates, reminders, and member assignment for checklist items. A new constant for due reminder options is added to the Trello common constants module. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CreateChecklistItemAction
participant TrelloAPI
User->>CreateChecklistItemAction: Provide checklist item details (name, due, dueReminder, idMember)
CreateChecklistItemAction->>TrelloAPI: Call createChecklistItem API with provided details
TrelloAPI-->>CreateChecklistItemAction: API response
CreateChecklistItemAction-->>User: Return created checklist item
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/trello/actions/create-checklist-item/create-checklist-item.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
components/trello/actions/delete-checklist/delete-checklist.mjs (1)
17-30:carIdtypo breaks prop linkage and dynamic optionsProperty is declared as
carId, but Trello components (and the propDefinition callback below) expectcardId.
This typo will:
- Prevent “Card” from showing in the UI (prop not recognised by the framework).
- Break the dynamic population of
checklistoptions (({ carId }) => ({ card: carId })passesundefined).Fix by renaming the prop everywhere:
- carId: { + cardId: { @@ - ({ carId }) => ({ - card: carId, + ({ cardId }) => ({ + card: cardId,After renaming, update any references in docs/tests if present.
Also applies to: 35-37
🧹 Nitpick comments (13)
components/trello/sources/new-activity/new-activity.mjs (1)
2-2: Import order tweak is harmless; consider lint rule to avoid future noiseRe-ordering the imports has no runtime impact, but it adds diff churn across large version-bump PRs. If you don’t already enforce a consistent import-sorting rule (e.g. via eslint-plugin-import), consider adding one so these reorderings don’t slip in accidentally.
components/trello/actions/get-list/get-list.mjs (1)
7-7: Patch-level bump looks fine – remember to update release artifactsThe version increment from
0.1.1→0.1.2is consistent with the cross-component bump in this PR and doesn’t affect runtime behaviour.
Just ensure any accompanying CHANGELOG / marketplace metadata is updated so downstream consumers see the new version.components/trello/sources/custom-webhook-events/custom-webhook-events.mjs (2)
9-9: Version bump is fine, but remember supporting artifactsThe patch-level version increase from
0.1.1→0.1.2looks correct and is consistent with the coordinated Trello source bumps in this PR.
Please make sure you also update any:
• CHANGELOG / release notes
• Docs / catalog metadata (if applicable)
so that users can discover what changed.
68-77: Potential rate-limit hit when resolvinglistIdfor every event
isRelevant()triggers an extra API call (getCardList) each time a webhook payload lackslist.id. On busy boards that can mean one additional request per event, quickly eating into Trello’s rate quotas and slowing event flow.- if (cardId && !listId) { - const res = await this.app.getCardList({ - cardId, - }); - listId = res.id; - } + if (cardId && !listId) { + // TODO: cache card→list mapping to avoid an API call per event + const res = await this.app.getCardList({ cardId }); + listId = res.id; + }Consider memoising the card→list lookup in memory (LRU cache) or persisting it in
this.dbto cut requests dramatically.components/trello/actions/search-checklists/search-checklists.mjs (1)
90-97: Collapse duplicatehiddenassignments for clarity
props.checkItemFields.hiddenis set twice, the second time overriding the first. A single, combined condition is clearer and avoids accidental divergence if logic evolves.- props.checkItems.hidden = !isCardSearch; - props.checkItemFields.hidden = !isCardSearch; - props.fields.hidden = !isCardSearch; - - props.checkItemFields.hidden = !(this.checkItems === "all"); + props.checkItems.hidden = !isCardSearch; + props.checkItemFields.hidden = !(isCardSearch && this.checkItems === "all"); + props.fields.hidden = !isCardSearch;This keeps behaviour identical while reducing cognitive load.
components/trello/actions/delete-checklist/delete-checklist.mjs (1)
28-29: Minor wording nitpick
"The ID of the card containing the checklist do delete"→"…to delete".- description: "The ID of the card containing the checklist do delete", + description: "The ID of the card containing the checklist to delete",components/trello/actions/create-card/create-card.mjs (1)
2-4: Import order tweak is fine, but keep grouping conventions consistentMoving the external
form-dataimport above the internalappimport follows common style (externals → internals). If the repo has an ESLint rule for alphabetical ordering across all imports rather than group-wise ordering, this may trigger a lint error. Double-check CI linting.No code change otherwise.
components/trello/common/constants.mjs (1)
120-122: Minor wording + casing nit“
At delivery time” is unusual Trello terminology; Trello UI says “At due time”. Also, labels elsewhere start with capital letters (“No reminder”).components/trello/actions/update-card/update-card.mjs (1)
9-9: Version bump acknowledgedMinor version increment to
0.2.2matches the cross-component release cadence. Make sure the changelog or release notes capture this bump so downstream users understand it’s a non-breaking update.components/trello/actions/add-attachment-to-card/add-attachment-to-card.mjs (1)
9-9: Minor version bump approvedAction moves to
1.0.1; no logic altered. Consider adding a one-liner to the changelog for completeness.components/trello/actions/create-board/create-board.mjs (1)
2-2: Import ordering nitpickThe project tends to place the
appimport first (see neighbouring actions). Swapping the order will add a tiny diff every time someone formats automatically.-import constants from "../../common/constants.mjs"; -import app from "../../trello.app.mjs"; +import app from "../../trello.app.mjs"; +import constants from "../../common/constants.mjs";Purely cosmetic—feel free to ignore if there is no agreed ordering rule.
components/trello/package.json (1)
3-3: Package minor bump aligns with new features
create-checklist-itemintroduced new props → minor bump to1.1.0is warranted.
Remember to update any CHANGELOG / release notes accordingly before publishing.components/trello/actions/create-checklist-item/create-checklist-item.mjs (1)
109-111: Consider adding error handling for parseInt.The
parseInt(dueReminder)could returnNaNif the value is invalid, which might cause API errors. SinceDUE_REMINDER_OPTIONSprovides predefined values, this is likely safe, but consider adding validation.- dueReminder: dueReminder - ? parseInt(dueReminder) - : undefined, + dueReminder: dueReminder + ? parseInt(dueReminder) || undefined + : undefined,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (42)
components/trello/actions/add-attachment-to-card/add-attachment-to-card.mjs(1 hunks)components/trello/actions/add-checklist/add-checklist.mjs(1 hunks)components/trello/actions/add-comment/add-comment.mjs(1 hunks)components/trello/actions/add-existing-label-to-card/add-existing-label-to-card.mjs(1 hunks)components/trello/actions/add-member-to-card/add-member-to-card.mjs(1 hunks)components/trello/actions/archive-card/archive-card.mjs(1 hunks)components/trello/actions/complete-checklist-item/complete-checklist-item.mjs(1 hunks)components/trello/actions/create-board/create-board.mjs(1 hunks)components/trello/actions/create-card/create-card.mjs(1 hunks)components/trello/actions/create-checklist-item/create-checklist-item.mjs(3 hunks)components/trello/actions/create-label/create-label.mjs(1 hunks)components/trello/actions/create-list/create-list.mjs(1 hunks)components/trello/actions/delete-checklist/delete-checklist.mjs(1 hunks)components/trello/actions/find-labels/find-labels.mjs(1 hunks)components/trello/actions/find-list/find-list.mjs(1 hunks)components/trello/actions/get-card/get-card.mjs(1 hunks)components/trello/actions/get-list/get-list.mjs(1 hunks)components/trello/actions/move-card-to-list/move-card-to-list.mjs(1 hunks)components/trello/actions/remove-label-from-card/remove-label-from-card.mjs(1 hunks)components/trello/actions/rename-list/rename-list.mjs(1 hunks)components/trello/actions/search-boards/search-boards.mjs(1 hunks)components/trello/actions/search-cards/search-cards.mjs(1 hunks)components/trello/actions/search-checklists/search-checklists.mjs(1 hunks)components/trello/actions/search-members/search-members.mjs(1 hunks)components/trello/actions/update-card/update-card.mjs(1 hunks)components/trello/common/constants.mjs(2 hunks)components/trello/package.json(1 hunks)components/trello/sources/card-archived/card-archived.mjs(1 hunks)components/trello/sources/card-due-date-reminder/card-due-date-reminder.mjs(1 hunks)components/trello/sources/card-moved/card-moved.mjs(1 hunks)components/trello/sources/card-updates/card-updates.mjs(1 hunks)components/trello/sources/custom-webhook-events/custom-webhook-events.mjs(1 hunks)components/trello/sources/new-activity/new-activity.mjs(1 hunks)components/trello/sources/new-attachment/new-attachment.mjs(1 hunks)components/trello/sources/new-board/new-board.mjs(1 hunks)components/trello/sources/new-card/new-card.mjs(1 hunks)components/trello/sources/new-checklist/new-checklist.mjs(1 hunks)components/trello/sources/new-comment-added-to-card/new-comment-added-to-card.mjs(1 hunks)components/trello/sources/new-label-added-to-card/new-label-added-to-card.mjs(1 hunks)components/trello/sources/new-label/new-label.mjs(1 hunks)components/trello/sources/new-member-on-card/new-member-on-card.mjs(1 hunks)components/trello/sources/new-notification/new-notification.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (17)
components/trello/actions/create-list/create-list.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/trello/package.json (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
components/trello/sources/new-board/new-board.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/trello/sources/new-activity/new-activity.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/trello/actions/create-label/create-label.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/trello/sources/new-card/new-card.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/trello/sources/custom-webhook-events/custom-webhook-events.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/trello/sources/new-label/new-label.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/trello/sources/new-attachment/new-attachment.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/trello/sources/new-label-added-to-card/new-label-added-to-card.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/trello/sources/new-checklist/new-checklist.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/trello/actions/create-card/create-card.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/trello/sources/card-updates/card-updates.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/trello/sources/new-comment-added-to-card/new-comment-added-to-card.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/trello/sources/card-due-date-reminder/card-due-date-reminder.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/trello/actions/create-board/create-board.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/trello/actions/create-checklist-item/create-checklist-item.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Publish TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (43)
components/trello/actions/complete-checklist-item/complete-checklist-item.mjs (1)
7-7: Version bump acknowledged and consistentPatch update to
0.2.2follows semantic-versioning conventions and matches the pattern applied across related Trello actions in this PR. No additional concerns.components/trello/actions/search-boards/search-boards.mjs (1)
7-7: Version bump LGTMThe minor version increment is consistent with other Trello action updates in this PR. No additional functional changes detected.
components/trello/sources/card-archived/card-archived.mjs (1)
9-9: Version bump is consistent across sources – good to merge
No functional changes introduced, and the increment aligns with the rest of the Trello components in this PR.components/trello/actions/archive-card/archive-card.mjs (1)
7-7: Patch-level version bump looks correct, but double-check cross-module consistencyThe change is limited to the version string; logic remains untouched.
Please confirm that every Trello action/source affected by this coordinated bump has been updated to the same patch level and that any CHANGELOG or marketplace metadata reflects0.2.2.components/trello/sources/new-activity/new-activity.mjs (1)
9-9: Version bump LGTM – confirm downstream referencesThe incremental bump to
0.1.2is consistent with the cross-component sync described in the PR. Just double-check that any hard-coded dependency/version checks (docs, tests, manifests) were updated accordingly.components/trello/sources/card-moved/card-moved.mjs (1)
9-9: Version bump LGTMThe increment aligns with the coordinated updates across related sources. No functional changes detected.
components/trello/actions/search-checklists/search-checklists.mjs (1)
7-7: Patch-level version bump looks correctIncrementing from
0.2.1to0.2.2follows semantic-versioning conventions for a non-functional change.components/trello/actions/remove-label-from-card/remove-label-from-card.mjs (1)
7-7: Version bump looks goodPatch-level increment to
0.2.2is consistent with the rest of the Trello actions and requires no further changes.components/trello/actions/rename-list/rename-list.mjs (1)
8-8: Version metadata correctly updated
0.1.2aligns with the bulk release; no additional changes needed.components/trello/actions/move-card-to-list/move-card-to-list.mjs (1)
8-8: Consistent version incrementThe bump to
0.2.2matches the coordinated package update.components/trello/actions/add-existing-label-to-card/add-existing-label-to-card.mjs (1)
7-7: Patch version bump acknowledged
0.1.2version tag is fine.components/trello/actions/delete-checklist/delete-checklist.mjs (1)
7-7: Version bump OKPatch-level change to
0.2.2is correct.components/trello/sources/new-label-added-to-card/new-label-added-to-card.mjs (1)
9-9: Version bump looks goodOnly the
versionfield was incremented. No functional impact. 👍components/trello/sources/new-label/new-label.mjs (1)
9-9: Patch-level version increment approvedConsistent with the coordinated Trello source bumps in this PR. Nothing else changed.
components/trello/actions/search-members/search-members.mjs (1)
7-7: Minor version increment acknowledged
0.2.1 → 0.2.2is appropriate for a no-code change. ✅components/trello/sources/new-notification/new-notification.mjs (1)
8-8: LGTM on version updateNo logic touched; patch bump is fine.
components/trello/actions/create-card/create-card.mjs (1)
10-10: Patch version bump (1.0.0 → 1.0.1) approvedReflects a non-functional change. 🚀
components/trello/common/constants.mjs (1)
167-167: Good job exporting the new constantExport list updated correctly — downstream components can now import
DUE_REMINDER_OPTIONS.components/trello/actions/find-list/find-list.mjs (1)
8-8: Version bump looks fineNo logic changes; publishing
0.2.2is consistent with other actions.components/trello/sources/new-board/new-board.mjs (1)
9-9: Version bump acknowledged
0.1.2accurately reflects a patch-level change with no code modifications.components/trello/actions/find-labels/find-labels.mjs (1)
8-8: Patch version update is consistentNothing else changed;
0.2.2is appropriate.components/trello/sources/new-member-on-card/new-member-on-card.mjs (1)
9-9: Version bump only
0.1.2patch increment OK.components/trello/actions/create-label/create-label.mjs (2)
1-3: Import reorder looks good ‑ maintains readability
No functional impact and keeps constants logically grouped before theappimport. 👍
8-8: Patch-level version bump acknowledged
0.2.2correctly signals a non-breaking change. Ensurepackage.jsonand CHANGELOG are updated in lock-step (looks like they are in this PR).components/trello/actions/create-list/create-list.mjs (1)
7-7: Version increment only – LGTM
No logic changes; patch bump is consistent with other Trello actions.components/trello/actions/add-checklist/add-checklist.mjs (1)
7-7: Version bump verified
Action behaviour untouched;0.2.2is appropriate.components/trello/actions/get-card/get-card.mjs (1)
8-8: Patch version aligned
No functional edits – safe to merge.components/trello/sources/new-attachment/new-attachment.mjs (1)
9-9: Source version bump looks correct
Keeps source components in sync with action versions.components/trello/actions/update-card/update-card.mjs (1)
2-3: Import reorder is fine – no impact on behaviorSwitching the order of
pickByandappimports does not affect execution and remains consistent with common style guides.components/trello/sources/new-comment-added-to-card/new-comment-added-to-card.mjs (1)
9-9: Source version bumpedPatch bump to
0.2.2is consistent with other sources; no code changes observed.components/trello/actions/search-cards/search-cards.mjs (1)
7-7: Action version bumped
0.2.2correctly signals the maintenance release. Implementation untouched – LGTM.components/trello/sources/card-updates/card-updates.mjs (1)
9-9: Patch version increment looks goodUpdate from
0.1.1→0.1.2keeps the source in sync with the package release; functionality unchanged.components/trello/actions/create-board/create-board.mjs (1)
8-8: Patch-level bump looks correctNo functional changes were made in this file, so
0.2.2is an appropriate patch release. 👍components/trello/actions/add-member-to-card/add-member-to-card.mjs (1)
7-7: Version bump only – LGTMThe patch bump keeps semantic versioning consistent with no code changes. Nothing else to flag.
components/trello/actions/add-comment/add-comment.mjs (1)
7-7: Patch bump OKNo behaviour changes detected;
0.2.2is appropriate.components/trello/sources/new-card/new-card.mjs (1)
9-9: Source version bump confirmedNothing else changed;
0.1.2keeps history clean. 👍components/trello/sources/new-checklist/new-checklist.mjs (1)
9-9: LGTM: Coordinated version increment.The version bump is part of a coordinated update across Trello components and follows proper semantic versioning.
components/trello/sources/card-due-date-reminder/card-due-date-reminder.mjs (2)
2-4: LGTM: Improved import organization.The import reordering groups dependencies logically, which improves code organization.
11-11: LGTM: Coordinated version increment.The version bump aligns with the coordinated update across Trello components.
components/trello/actions/create-checklist-item/create-checklist-item.mjs (4)
1-1: LGTM: Correct import for new functionality.The import of
DUE_REMINDER_OPTIONSproperly supports the new due reminder feature.
8-8: LGTM: Appropriate version increment for new features.The version bump to 0.3.0 correctly reflects the addition of new functionality following semantic versioning.
60-88: LGTM: Well-structured new properties.The three new optional properties are properly defined with appropriate types, labels, descriptions, and prop definitions. The
idMemberprop correctly usesexcludeCardMembers: trueto prevent assigning users already on the card.
96-99: LGTM: Clean integration of new parameters.The destructuring and API parameter passing cleanly integrates the new functionality without affecting existing logic.
Also applies to: 108-113
jcortes
left a comment
jcortes
left a comment
There was a problem hiding this comment.
Hi @luancazarine lgtm! Ready for QA!
|
/approve |
luancazarine
deleted the
17241-feature-enhance-trello---create-checklist-item
branch
Resolves #17241
Summary by CodeRabbit
New Features
Chores