fix(connect-react): exclude 'dir' from configurable props #17370
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
WalkthroughThe update increments the version of the Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/connect-react/src/hooks/form-context.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/connect-react/src/hooks/form-context.tsx (1)
49-55: Nit: keep the list alphabetically ordered for readability.For quick scanning later, consider sorting the array:
"dir", "$.interface.apphook", "$.interface.http", "$.interface.timer", "$.service.db",packages/connect-react/CHANGELOG.md (1)
5-10: Changelog entry is clear – consider moving under “Fixed” instead of “Changed”.SemVer patch releases normally document bug fixes under a Fixed heading. If that’s your convention, swapping the heading will avoid confusion.
-## Changed +## Fixed
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
packages/connect-react/CHANGELOG.md(1 hunks)packages/connect-react/package.json(1 hunks)packages/connect-react/src/hooks/form-context.tsx(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: jverce
PR: PipedreamHQ/pipedream#15479
File: packages/connect-react/src/components/ComponentForm.tsx:23-24
Timestamp: 2025-02-05T21:58:03.118Z
Learning: In the connect-react package, the `enableDebugging` property should be of type `boolean` as it's used for toggling debugging features and conditional rendering.
packages/connect-react/CHANGELOG.md (1)
Learnt from: jverce
PR: PipedreamHQ/pipedream#15479
File: packages/connect-react/src/components/ComponentForm.tsx:23-24
Timestamp: 2025-02-05T21:58:03.118Z
Learning: In the connect-react package, the `enableDebugging` property should be of type `boolean` as it's used for toggling debugging features and conditional rendering.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: pnpm publish
🔇 Additional comments (2)
packages/connect-react/package.json (1)
3-3: Version bump looks good – verify build artifacts are regenerated.After incrementing the version, make sure
pnpm run build(triggered by thepreparescript) has been executed so that the new1.3.1banner is baked into thedistbundles before publishing.packages/connect-react/src/hooks/form-context.tsx (1)
49-55: 👍"dir"correctly added toskippablePropTypes.This keeps the non-configurable prop out of the form and aligns with the PR objective. No further action needed.
WHY
The 'dir' prop is not configurable and should not be shown in the prop form.
Example (Connect demo):
unsupported-prop-type-dir.mov
Summary by CodeRabbit
Bug Fixes
Chores