Notion - create-page-from-database update props #17471
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThe changes update version numbers for several Notion action components, introduce a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CreatePageFromDBAction
participant Utils
User->>CreatePageFromDBAction: Provide Name, properties, icon, cover
CreatePageFromDBAction->>Utils: parseObject(properties)
Utils-->>CreatePageFromDBAction: Parsed properties object
CreatePageFromDBAction->>CreatePageFromDBAction: Build Notion page payload
CreatePageFromDBAction-->>User: Return created page
Assessment against linked issues
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/notion/actions/append-block/append-block.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/notion/actions/create-page/create-page.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/notion/actions/create-page-from-database/create-page-from-database.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
components/notion/actions/append-block/append-block.mjs(1 hunks)components/notion/actions/create-page-from-database/create-page-from-database.mjs(3 hunks)components/notion/actions/create-page/create-page.mjs(1 hunks)components/notion/actions/duplicate-page/duplicate-page.mjs(1 hunks)components/notion/actions/query-database/query-database.mjs(1 hunks)components/notion/actions/update-page/update-page.mjs(1 hunks)components/notion/common/utils.mjs(1 hunks)components/notion/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/notion/package.json (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
components/notion/actions/duplicate-page/duplicate-page.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/notion/actions/create-page/create-page.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/notion/actions/create-page-from-database/create-page-from-database.mjs (2)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/column-value-updated/column-value-updated.mjs:17-24
Timestamp: 2025-01-23T03:55:51.998Z
Learning: Alert props in Pipedream components are a special case that do not require a label property, and use the 'content' property as a replacement for description.
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (10)
components/notion/package.json (1)
3-3: LGTM: Appropriate version bump for new features.The minor version bump from 0.6.2 to 0.7.0 is appropriate for this release, which includes new utility functions and refactored actions.
components/notion/actions/append-block/append-block.mjs (1)
10-10: LGTM: Coordinated version bump for package release.The patch version increment aligns with the coordinated release approach across all Notion actions.
components/notion/actions/query-database/query-database.mjs (1)
8-8: LGTM: Appropriate version bump for coordinated release.The patch version increment is consistent with the package-wide release approach.
components/notion/actions/duplicate-page/duplicate-page.mjs (1)
10-10: LGTM: Consistent version bump for package release.The patch version increment follows the coordinated release pattern across all Notion actions.
components/notion/actions/update-page/update-page.mjs (1)
10-10: Version bump looks good.The version increment from 1.1.6 to 1.1.7 aligns with the coordinated package update across Notion components.
components/notion/actions/create-page/create-page.mjs (1)
10-10: Version bump looks good.The version increment from 0.2.16 to 0.2.17 aligns with the coordinated package update across Notion components.
components/notion/actions/create-page-from-database/create-page-from-database.mjs (4)
3-4: Good import updates for the new functionality.The replacement of
pickfrom lodash-es withNOTION_ICONSandutilsaligns well with the new explicit props approach and the addition of icon options.
11-11: Appropriate version bump for breaking changes.The version increment from 0.1.18 to 0.2.0 correctly reflects the breaking changes in the props structure and removal of dynamic prop loading.
23-46: Well-structured explicit props replace dynamic loading.The new props structure is clear and user-friendly:
Nameprop provides explicit page namingpropertiesprop has detailed documentation for schema matchingiconprop leverages the NOTION_ICONS optionscoverprop supports external URLs- All optional props are appropriately marked
This approach is more predictable than the previous dynamic prop loading.
68-68: Good addition of property parsing.The
utils.parseObject(this.properties)call ensures that the properties input is correctly parsed before building page properties, which is essential for handling various input formats.
Resolves #17206
Summary by CodeRabbit
New Features
Improvements
Chores