Github - list-commits & get-commit actions #17474
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update introduces two new GitHub actions—one for listing commits and another for retrieving a specific commit—alongside supporting methods and prop definitions in the GitHub app module. Additionally, it increments version numbers and updates documentation URLs across multiple GitHub action and source components without altering their logic. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ListCommitsAction
participant GithubApp
User->>ListCommitsAction: Provide repoFullname and filters
ListCommitsAction->>GithubApp: listCommits({ repoFullname, ...filters })
GithubApp->>Github API: GET /repos/{repoFullname}/commits
Github API-->>GithubApp: List of commits
GithubApp-->>ListCommitsAction: Commits list
ListCommitsAction-->>User: Return commits
User->>GetCommitAction: Provide repoFullname and commitSha
GetCommitAction->>GithubApp: getCommit({ repoFullname, commitRef })
GithubApp->>Github API: GET /repos/{repoFullname}/commits/{commitRef}
Github API-->>GithubApp: Commit data
GithubApp-->>GetCommitAction: Commit data
GetCommitAction-->>User: Return commit
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/github/actions/create-issue-comment/create-issue-comment.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/github/actions/create-branch/create-branch.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/github/actions/create-or-update-file-contents/create-or-update-file-contents.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
components/github/actions/create-branch/create-branch.mjs (1)
37-46: Potential misuse ofbranchShapropThe input prop
branchShais documented as “Source Branch”, but later the code mutates it to hold a commit SHA:this.branchSha = this.branchSha.split("/")[0]; // strips to first path element … this.branchSha = masterBranch[0].commit.sha; // now a full SHAMixing a branch name (or ref) with a commit SHA in the same variable can be confusing and error-prone. Consider:
- Renaming the prop to
sourceBranchand introducing a separatesourceShalocal variable.- Avoiding the destructive reassignment of
this.branchSha; instead compute a localsourceShavalue that is eventually passed to the API.This will make the component clearer and safer when future logic is added.
🧹 Nitpick comments (9)
components/github/sources/new-star-by-user/new-star-by-user.mjs (1)
8-8: Version bump is fine – remember to update the changelogThe metadata bump to
0.0.10is consistent with the coordinated release. No functional impact detected.Consider adding an entry in the package‐level CHANGELOG so consumers can track what changed between 0.0.9 and 0.0.10.
components/github/package.json (1)
3-3: Minor version bump looks consistentMoving from
1.7.2→1.8.0correctly signals new, backward-compatible features. Ensure any release notes or tags reflect the new commit- and branch-oriented actions added in this PR.components/github/actions/get-issue-assignees/get-issue-assignees.mjs (1)
6-7: Fix “Gihub” typo in descriptionMinor spelling issue in the public description string.
- description: "Get assignees for an issue in a Gihub repo. [See the documentation](https://docs.github.com/en/rest/issues/issues#get-an-issue)", + description: "Get assignees for an issue in a GitHub repo. [See the documentation](https://docs.github.com/en/rest/issues/issues#get-an-issue)",components/github/actions/create-issue/create-issue.mjs (1)
8-9: Correct the “Gihub” typoSame typo as elsewhere—quick cosmetic fix.
- description: "Create a new issue in a Gihub repo. [See the documentation](https://docs.github.com/en/rest/issues/issues#create-an-issue)", + description: "Create a new issue in a GitHub repo. [See the documentation](https://docs.github.com/en/rest/issues/issues#create-an-issue)",components/github/sources/new-gist/new-gist.mjs (1)
7-7: Fix typo in description
documentatoion→documentation.- description: "Emit new events when new gists are created by the authenticated user. [See the documentatoion](https://docs.github.com/en/rest/gists/gists?apiVersion=20.2.51-28#list-gists-for-the-authenticated-user)", + description: "Emit new events when new gists are created by the authenticated user. [See the documentation](https://docs.github.com/en/rest/gists/gists?apiVersion=20.2.51-28#list-gists-for-the-authenticated-user)",components/github/sources/new-team/new-team.mjs (1)
7-7: Consider plural “events” for consistencyMost GitHub source descriptions use “Emit new events …”. Switching to plural keeps messaging uniform.
- description: "Emit new event when the authenticated user is added to a new team. [See the documentation](https://docs.github.com/en/rest/teams/teams?apiVersion=20.2.51-28#list-teams-for-the-authenticated-user)", + description: "Emit new events when the authenticated user is added to a new team. [See the documentation](https://docs.github.com/en/rest/teams/teams?apiVersion=20.2.51-28#list-teams-for-the-authenticated-user)",components/github/sources/new-repository/new-repository.mjs (1)
7-7: Align wording with other sourcesReplace singular “event” with plural “events” for consistency across components.
- description: "Emit new event when a new repository is created or when the authenticated user receives access. [See the documentation](https://docs.github.com/en/rest/repos/repos?apiVersion=20.2.51-28#list-repositories-for-the-authenticated-user)", + description: "Emit new events when a new repository is created or when the authenticated user receives access. [See the documentation](https://docs.github.com/en/rest/repos/repos?apiVersion=20.2.51-28#list-repositories-for-the-authenticated-user)",components/github/sources/new-review-request/new-review-request.mjs (1)
7-7: Minor wording tweakPluralising “events” keeps phrasing consistent with other components.
- description: "Emit new event for new review request notifications. [See the documentation](https://docs.github.com/en/rest/activity/notifications?apiVersion=20.2.51-28#list-notifications-for-the-authenticated-user)", + description: "Emit new events for new review request notifications. [See the documentation](https://docs.github.com/en/rest/activity/notifications?apiVersion=20.2.51-28#list-notifications-for-the-authenticated-user)",components/github/sources/new-notification/new-notification.mjs (1)
7-7: Keep wording consistentUse “events” (plural) to match other GitHub sources.
- description: "Emit new event when the authenticated user receives a new notification. [See the documentation](https://docs.github.com/en/rest/activity/notifications?apiVersion=20.2.51-28#list-notifications-for-the-authenticated-user)", + description: "Emit new events when the authenticated user receives a new notification. [See the documentation](https://docs.github.com/en/rest/activity/notifications?apiVersion=20.2.51-28#list-notifications-for-the-authenticated-user)",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (54)
components/github/actions/create-branch/create-branch.mjs(1 hunks)components/github/actions/create-gist/create-gist.mjs(1 hunks)components/github/actions/create-issue-comment/create-issue-comment.mjs(1 hunks)components/github/actions/create-issue/create-issue.mjs(1 hunks)components/github/actions/create-or-update-file-contents/create-or-update-file-contents.mjs(1 hunks)components/github/actions/create-pull-request/create-pull-request.mjs(1 hunks)components/github/actions/create-repository/create-repository.mjs(1 hunks)components/github/actions/create-workflow-dispatch/create-workflow-dispatch.mjs(1 hunks)components/github/actions/disable-workflow/disable-workflow.mjs(1 hunks)components/github/actions/enable-workflow/enable-workflow.mjs(1 hunks)components/github/actions/get-commit/get-commit.mjs(1 hunks)components/github/actions/get-issue-assignees/get-issue-assignees.mjs(1 hunks)components/github/actions/get-repository-content/get-repository-content.mjs(1 hunks)components/github/actions/get-repository/get-repository.mjs(1 hunks)components/github/actions/get-reviewers/get-reviewers.mjs(1 hunks)components/github/actions/get-workflow-run/get-workflow-run.mjs(1 hunks)components/github/actions/list-commits/list-commits.mjs(1 hunks)components/github/actions/list-gists-for-a-user/list-gists-for-a-user.mjs(1 hunks)components/github/actions/list-releases/list-releases.mjs(1 hunks)components/github/actions/list-workflow-runs/list-workflow-runs.mjs(1 hunks)components/github/actions/search-issues-and-pull-requests/search-issues-and-pull-requests.mjs(1 hunks)components/github/actions/star-repo/star-repo.mjs(1 hunks)components/github/actions/update-gist/update-gist.mjs(1 hunks)components/github/actions/update-issue/update-issue.mjs(1 hunks)components/github/actions/update-project-v2-item-status/update-project-v2-item-status.mjs(1 hunks)components/github/github.app.mjs(2 hunks)components/github/package.json(1 hunks)components/github/sources/new-branch/new-branch.mjs(1 hunks)components/github/sources/new-card-in-column/new-card-in-column.mjs(1 hunks)components/github/sources/new-collaborator/new-collaborator.mjs(1 hunks)components/github/sources/new-commit-comment/new-commit-comment.mjs(1 hunks)components/github/sources/new-commit/new-commit.mjs(1 hunks)components/github/sources/new-discussion/new-discussion.mjs(1 hunks)components/github/sources/new-fork/new-fork.mjs(1 hunks)components/github/sources/new-gist/new-gist.mjs(1 hunks)components/github/sources/new-issue-comment/new-issue-comment.mjs(1 hunks)components/github/sources/new-issue-with-status/new-issue-with-status.mjs(1 hunks)components/github/sources/new-label/new-label.mjs(1 hunks)components/github/sources/new-mention/new-mention.mjs(1 hunks)components/github/sources/new-notification/new-notification.mjs(1 hunks)components/github/sources/new-or-updated-issue/new-or-updated-issue.mjs(1 hunks)components/github/sources/new-or-updated-milestone/new-or-updated-milestone.mjs(1 hunks)components/github/sources/new-or-updated-pull-request/new-or-updated-pull-request.mjs(1 hunks)components/github/sources/new-organization/new-organization.mjs(1 hunks)components/github/sources/new-release/new-release.mjs(1 hunks)components/github/sources/new-repository/new-repository.mjs(1 hunks)components/github/sources/new-review-request/new-review-request.mjs(1 hunks)components/github/sources/new-security-alert/new-security-alert.mjs(1 hunks)components/github/sources/new-star-by-user/new-star-by-user.mjs(1 hunks)components/github/sources/new-star/new-star.mjs(1 hunks)components/github/sources/new-team/new-team.mjs(1 hunks)components/github/sources/new-workflow-job-completed/new-workflow-job-completed.mjs(1 hunks)components/github/sources/new-workflow-run-completed/new-workflow-run-completed.mjs(1 hunks)components/github/sources/webhook-events/webhook-events.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (21)
components/github/package.json (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
components/github/sources/new-or-updated-milestone/new-or-updated-milestone.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-label/new-label.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-commit/new-commit.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/webhook-events/webhook-events.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/github/actions/create-issue/create-issue.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/github/sources/new-workflow-job-completed/new-workflow-job-completed.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/github/sources/new-commit-comment/new-commit-comment.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-branch/new-branch.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-issue-with-status/new-issue-with-status.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-or-updated-issue/new-or-updated-issue.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-gist/new-gist.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/github/sources/new-card-in-column/new-card-in-column.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-organization/new-organization.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-security-alert/new-security-alert.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-review-request/new-review-request.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-notification/new-notification.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-team/new-team.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/sources/new-mention/new-mention.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/github/actions/list-commits/list-commits.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/github/actions/get-commit/get-commit.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (50)
components/github/sources/new-fork/new-fork.mjs (1)
11-11: Version bump looks good.Clean version increment from "1.0.10" to "1.0.11" with no functional changes.
components/github/github.app.mjs (4)
317-335: Well-implemented prop definition for branch SHA selection.The
branchShaprop correctly fetches branches with pagination and maps them to user-friendly labels with commit SHA values. The implementation follows existing patterns in the codebase.
336-350: Clean implementation of commit SHA prop definition.The
commitShaprop properly integrates with the newlistCommitsmethod and provides a clean interface for commit selection. The pagination and mapping logic is consistent with other prop definitions.
937-942: Correct implementation of getCommit method.The method properly uses the GitHub REST API endpoint for retrieving individual commits and follows the established pattern for API calls in this module.
943-948: Solid implementation of listCommits method.The method correctly uses the GitHub REST API endpoint for listing commits and properly spreads additional arguments for flexible parameter passing.
components/github/sources/new-workflow-run-completed/new-workflow-run-completed.mjs (1)
10-10: Version bump approved.Clean version increment from "0.0.3" to "0.0.4" with no functional changes.
components/github/sources/new-or-updated-milestone/new-or-updated-milestone.mjs (1)
12-12: Version increment looks good.Clean version bump from "1.1.7" to "1.1.8" with no functional changes.
components/github/sources/new-branch/new-branch.mjs (1)
11-11: Version bump approved.Clean version increment from "1.0.10" to "1.0.11" with no functional changes.
components/github/sources/new-label/new-label.mjs (1)
11-11: Version increment acknowledgedNo functional code touched – looks good.
components/github/sources/new-star/new-star.mjs (1)
11-11: Version bump only – all goodComponent logic unchanged.
components/github/sources/new-issue-comment/new-issue-comment.mjs (1)
11-11: Patch-level version update verifiedNo additional action required.
components/github/sources/new-commit-comment/new-commit-comment.mjs (1)
11-11: Minor version bump confirmedChange is isolated to metadata.
components/github/sources/new-collaborator/new-collaborator.mjs (1)
11-11: Metadata update looks correctNothing else modified – approved.
components/github/sources/new-discussion/new-discussion.mjs (1)
11-11: Version bump looks goodOnly metadata updated. No functional impact detected.
components/github/sources/new-workflow-job-completed/new-workflow-job-completed.mjs (1)
10-10: Version increment acknowledgedChange is confined to the version field; implementation unchanged.
components/github/sources/new-or-updated-issue/new-or-updated-issue.mjs (1)
12-12: Semantic version bump acceptedConsistent with other components in the release set.
components/github/sources/new-issue-with-status/new-issue-with-status.mjs (1)
11-11: Metadata update onlyNo code path altered; safe to merge.
components/github/sources/new-card-in-column/new-card-in-column.mjs (1)
10-10: LGTM on version updateVersion field aligned with release cadence.
components/github/actions/disable-workflow/disable-workflow.mjs (1)
8-8: Metadata updated onlyNo logic touched;
0.0.4version bump aligns with other actions. ✅components/github/actions/update-gist/update-gist.mjs (1)
9-9: Version bump acknowledgedIncrement to
0.0.11without code changes looks good.components/github/sources/webhook-events/webhook-events.mjs (1)
11-11: Source version increment is OK
1.0.11continues the semver patch path. No behavioral changes detected.components/github/actions/get-repository/get-repository.mjs (1)
7-7: Version bump looks goodPatch-level increment only—no functional impact observed.
components/github/actions/create-gist/create-gist.mjs (1)
8-8: Version bump looks goodConsistent with other actions in this PR.
components/github/actions/list-workflow-runs/list-workflow-runs.mjs (1)
7-7: Version bump looks goodNo logic changes detected.
components/github/actions/star-repo/star-repo.mjs (1)
8-8: Version bump looks goodMetadata update only.
components/github/actions/list-gists-for-a-user/list-gists-for-a-user.mjs (1)
8-8: Version bump looks goodAligned with package version update.
components/github/sources/new-commit/new-commit.mjs (1)
11-11: Version bump looks fineNo functional change; metadata stays in sync with the rest of the package updates.
components/github/actions/create-branch/create-branch.mjs (1)
8-8: Metadata only – LGTMVersion increment is consistent with the coordinated release.
components/github/actions/list-releases/list-releases.mjs (1)
7-7: Version bump acknowledgedNothing else changed; good to merge.
components/github/actions/get-workflow-run/get-workflow-run.mjs (1)
7-7: Version bump onlyLooks correct and consistent with the other action updates.
components/github/actions/search-issues-and-pull-requests/search-issues-and-pull-requests.mjs (1)
7-7: Metadata update verifiedNo functional changes; version bump is fine.
components/github/actions/update-project-v2-item-status/update-project-v2-item-status.mjs (1)
7-7: Patch-level version increment recorded
0.0.5 → 0.0.6aligns with the other coordinated bumps in this PR. No further action required.components/github/actions/create-issue-comment/create-issue-comment.mjs (1)
7-7: Patch-level version increment recorded
0.0.21 → 0.0.22looks consistent with the repo-wide version bumps.components/github/actions/update-issue/update-issue.mjs (1)
13-13: Patch-level version increment recorded
0.2.3 → 0.2.4is coherent with other components’ updates. Nothing else to flag.components/github/actions/enable-workflow/enable-workflow.mjs (1)
7-7: Patch-level version increment recorded
0.0.3 → 0.0.4follows the coordinated release pattern. LGTM.components/github/actions/create-or-update-file-contents/create-or-update-file-contents.mjs (1)
7-7: Patch-level version increment recorded
0.1.3 → 0.1.4is in line with the rest of the action bumps. All good.components/github/actions/create-workflow-dispatch/create-workflow-dispatch.mjs (1)
8-8: Version bump looks goodNo functional changes detected. 👍
components/github/sources/new-release/new-release.mjs (1)
11-11: Routine version increment acknowledgedAll good here.
components/github/actions/get-repository-content/get-repository-content.mjs (1)
7-7: Consistent version bumpMatches the package-wide update; no concerns.
components/github/sources/new-or-updated-pull-request/new-or-updated-pull-request.mjs (1)
12-12: Version updated successfullyChange is isolated to metadata.
components/github/actions/get-reviewers/get-reviewers.mjs (1)
9-9: Metaversion update confirmedNo logic touched; everything aligns.
components/github/actions/create-repository/create-repository.mjs (1)
7-7: Version bump looks correctNo functional changes—only the version was incremented. 👍
components/github/actions/create-pull-request/create-pull-request.mjs (1)
8-8: Consistent patch-level version incrementAligns with the coordinated release across actions. Nothing else to address.
components/github/actions/get-issue-assignees/get-issue-assignees.mjs (1)
7-7: Version bump OKPatch version moved to 0.0.22 without logic changes.
components/github/actions/create-issue/create-issue.mjs (1)
9-9: Version bump acknowledgedNo further action required.
components/github/sources/new-organization/new-organization.mjs (1)
8-9: Doc URL & version bump look goodUpdated API version reference and component version are consistent with the broader release.
components/github/sources/new-mention/new-mention.mjs (1)
7-8: LGTM! Metadata updates are consistent.The documentation URL and version updates align with the broader GitHub component version increments mentioned in the PR summary.
components/github/sources/new-security-alert/new-security-alert.mjs (1)
7-8: LGTM! Consistent metadata updates.The documentation URL and version updates match the pattern applied across other GitHub source components in this PR.
components/github/actions/get-commit/get-commit.mjs (1)
1-37: VerifiedgetCommitExists in GitHub App ModuleThe
async getCommitmethod is implemented in components/github/github.app.mjs (lines 937–942) and accepts{ repoFullname, commitRef }, matching the action’s usage ofthis.github.getCommit({ repoFullname, commitRef: this.commitSha }).All parameters align and the summary export is correctly formatted. Approving these changes.
components/github/actions/list-commits/list-commits.mjs (1)
1-82: Approved:listCommitsmethod verified and action looks solid
- Confirmed
listCommitsis defined in components/github/github.app.mjs:async listCommits({ repoFullname, ...args }) { const response = await this._client().request( `GET /repos/${repoFullname}/commits`, args ); return response.data; }- The
list-commitsaction correctly invokes this method, exposes all intended filters, and exports a proper summary.No further changes required.
jcortes
left a comment
jcortes
left a comment
There was a problem hiding this comment.
Hi @michelle0927 lgtm! Ready for QA!
Resolves #17048
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes
Chores