Skip to content

Conversation

@dannyroosevelt
Copy link
Collaborator

@dannyroosevelt dannyroosevelt commented Jul 7, 2025

Summary

  • Fixed the get-teams action in the Linear component to properly inherit props from the parent linear_app component
  • Added utils.getAppProps() to ensure all props (including limit) are correctly imported
  • Bumped versions: get-teams action to 0.2.11 and linear package to 0.7.3

Test plan

  • Publish the linear get-teams action
  • Verify that the limit prop appears in the action configuration
  • Test that the limit prop works correctly when set

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies and version numbers for improved consistency and maintenance.

dannyroosevelt and others added 2 commits July 6, 2025 19:56
The get-teams action was not properly inheriting props from the parent linear_app component. Added utils.getAppProps() to ensure all props (including limit) are correctly imported.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 7, 2025

Walkthrough

The changes update the version numbers in both the get-teams action and the package manifest. The get-teams action now imports utility functions from a shared module and uses a utility method to populate properties, replacing the previous explicit property assignment. No public API signatures were altered.

Changes

File(s) Change Summary
components/linear/actions/get-teams/get-teams.mjs Switched to using shared utilities for property assignment; removed explicit linearApp import; updated version to 0.2.11
components/linear/package.json Incremented package version from 0.7.2 to 0.7.3

Poem

A hop, a skip, a version up high,
Utilities shared as the code hops by.
Teams now gathered with a single call,
No more explicit props to install.
The package grows, the numbers climb—
A rabbit’s work, in tidy rhyme! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/linear/actions/get-teams/get-teams.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

Warning

Review ran into problems

🔥 Problems

Check-run timed out after 90 seconds. Some checks/pipelines were still in progress when the timeout was reached. Consider increasing the reviews.tools.github-checks.timeout_ms value in your CodeRabbit configuration to allow more time for checks to complete.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 886cf86 and b22c5c1.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • components/linear/actions/get-teams/get-teams.mjs (1 hunks)
  • components/linear/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
components/linear/package.json (2)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Learnt from: js07
PR: PipedreamHQ/pipedream#17375
File: components/zerobounce/actions/get-validation-results-file/get-validation-results-file.mjs:23-27
Timestamp: 2025-07-01T17:07:48.193Z
Learning: "dir" props in Pipedream components are hidden in the component form and not user-facing, so they don't require labels or descriptions for user clarity.
components/linear/actions/get-teams/get-teams.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: pnpm publish
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Lint Code Base
🔇 Additional comments (4)
components/linear/package.json (1)

3-3: Version bump looks appropriate for the bug fix.

The version increment from 0.7.2 to 0.7.3 aligns with the coordinated versioning strategy for this bug fix.

components/linear/actions/get-teams/get-teams.mjs (3)

13-13: Version bump is appropriate for the bug fix.

The version increment from 0.2.10 to 0.2.11 is appropriate for this bug fix that adds the missing limit property functionality.


10-10: utils.getAppProps(getTeams) correctly includes limit prop
The getAppProps utility destructures and re-spreads all properties from component.props (aside from the linearApp binding), so the limit definition on getTeams is carried through. No further changes are required.


2-2: Confirm ‘limit’ Prop Is Passed Through

We’ve verified that:

  • components/linear/common/utils.mjs exists and exports getAppProps.
  • getAppProps correctly destructures component.props, then returns props: { linearApp, …buildPropDefinitions({ app: linearApp, props: otherProps }) }.
  • buildPropDefinitions spreads all entries from otherProps (including limit).

Next step—please verify that the original getTeams.props (from @pipedream/linear_app/actions/get-teams/get-teams.mjs) actually defines a limit property so it’s passed through successfully.

Locations to check:

  • components/linear/actions/get-teams/get-teams.mjs (use of …utils.getAppProps(getTeams))
  • @pipedream/linear_app/actions/get-teams/get-teams.mjs (prop definitions for limit)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link

vercel bot commented Jul 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Jul 7, 2025 2:58am
pipedream-docs ⬜️ Ignored (Inspect) Jul 7, 2025 2:58am
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Jul 7, 2025 2:58am

@dannyroosevelt dannyroosevelt merged commit 827dd7b into master Jul 7, 2025
11 checks passed
@dannyroosevelt dannyroosevelt deleted the fix-linear-get-teams-limit-prop branch July 7, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants