-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New Components - freshchat #17572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Components - freshchat #17572
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
""" WalkthroughA comprehensive Freshchat integration has been added, including a full app client, multiple actions (fetching conversation details, sending messages, updating status, listing agents and channels), and source components for new conversations and messages. Supporting files for prop definitions, pagination, and test events are also included. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Action
participant FreshchatApp
participant FreshchatAPI
User->>Action: Triggers action (e.g., Send Message, Fetch Details)
Action->>FreshchatApp: Calls method (e.g., sendMessageInChat)
FreshchatApp->>FreshchatAPI: Makes HTTP request
FreshchatAPI-->>FreshchatApp: Returns response
FreshchatApp-->>Action: Returns processed data
Action-->>User: Returns result/summary
sequenceDiagram
participant Source
participant FreshchatApp
participant FreshchatAPI
participant DB
Source->>DB: Get last processed state
Source->>FreshchatApp: Fetch entities (conversations/messages)
FreshchatApp->>FreshchatAPI: Make paginated API calls
FreshchatAPI-->>FreshchatApp: Return data
FreshchatApp-->>Source: Return list
Source->>DB: Update state with new IDs/timestamps
Source-->>Source: Emit new events
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/freshchat/actions/send-message-in-chat/send-message-in-chat.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (6)
components/freshchat/actions/update-conversation-status/update-conversation-status.mjs (1)
52-59: Consider conditional assignment of agent ID.The
assigned_agent_idis always sent in the request payload, even when not needed. Consider only including it when relevant.- const response = await this.freshchat.updateConversation({ - $, - conversationId: this.conversationId, - data: { - status: this.status, - assigned_agent_id: this.agentId, - }, - }); + const data = { + status: this.status, + }; + if (this.agentId) { + data.assigned_agent_id = this.agentId; + } + const response = await this.freshchat.updateConversation({ + $, + conversationId: this.conversationId, + data, + });components/freshchat/sources/new-message-received/new-message-received.mjs (1)
45-75: Consider simplifying the maxCreatedTime logic.The current logic for tracking
maxCreatedTimeis complex and could be simplified.async processEvents(max) { const lastCreatedTime = this._getLastCreatedTime(); - let maxCreatedTime = lastCreatedTime; + let maxCreatedTime = null; const results = this.freshchat.paginate({ fn: this.freshchat.listMessages, args: { conversationId: this.conversationId, }, resourceKey: "messages", }); let messages = []; for await (const message of results) { if (!lastCreatedTime || Date.parse(message.created_time) > Date.parse(lastCreatedTime)) { - if (!maxCreatedTime || Date.parse(message.created_time) > Date.parse(maxCreatedTime)) { - maxCreatedTime = message.created_time; - } + maxCreatedTime = maxCreatedTime || message.created_time; + if (Date.parse(message.created_time) > Date.parse(maxCreatedTime)) { + maxCreatedTime = message.created_time; + } messages.push(message); } } - this._setLastCreatedTime(maxCreatedTime); + if (maxCreatedTime) { + this._setLastCreatedTime(maxCreatedTime); + }components/freshchat/actions/list-agents/list-agents.mjs (1)
42-68: Consider more specific error handling.The current error handling converts all non-404 errors to
ConfigurationError, which might mask other types of API errors that aren't configuration-related.} catch (e) { if (e.status === 404) { $.export("$summary", "No agents found"); + return []; + } else if (e.status >= 400 && e.status < 500) { + throw new ConfigurationError(e.message || e); } else { - throw new ConfigurationError(e); + throw e; } }components/freshchat/actions/fetch-conversation-details/fetch-conversation-details.mjs (1)
27-33: Consider passing the $ parameter to the API call.The API call doesn't pass the
$parameter, which might be needed for proper error handling and logging.const response = await this.freshchat.getConversation({ + $, conversationId: this.conversationId, });components/freshchat/sources/new-conversation-started/new-conversation-started.mjs (1)
49-52: Simplify previousIds storage structureThe current implementation stores conversation IDs as both keys and values, which is redundant. Consider using a Set-like structure or just storing true as the value.
Apply this refactor:
this._setPreviousIds(conversations.reduce((acc, conversation) => { - acc[conversation.id] = conversation.id; + acc[conversation.id] = true; return acc; }, {}));components/freshchat/freshchat.app.mjs (1)
86-86: Avoid mutating function parametersDirect mutation of parameters is not a best practice. Use a new variable instead.
-page = page + 1; +const currentPage = page + 1;Then use
currentPagein the subsequent API calls instead ofpage.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (12)
components/freshchat/actions/fetch-conversation-details/fetch-conversation-details.mjs(1 hunks)components/freshchat/actions/list-agents/list-agents.mjs(1 hunks)components/freshchat/actions/list-channels/list-channels.mjs(1 hunks)components/freshchat/actions/send-message-in-chat/send-message-in-chat.mjs(1 hunks)components/freshchat/actions/update-conversation-status/update-conversation-status.mjs(1 hunks)components/freshchat/freshchat.app.mjs(1 hunks)components/freshchat/package.json(2 hunks)components/freshchat/sources/common/base.mjs(1 hunks)components/freshchat/sources/new-conversation-started/new-conversation-started.mjs(1 hunks)components/freshchat/sources/new-conversation-started/test-event.mjs(1 hunks)components/freshchat/sources/new-message-received/new-message-received.mjs(1 hunks)components/freshchat/sources/new-message-received/test-event.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (12)
components/freshchat/package.json (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
components/freshchat/sources/new-message-received/test-event.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/freshchat/sources/common/base.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The `processTimerEvent` method in the `components/salesforce_rest_api/sources/common.mjs` file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/freshchat/sources/new-conversation-started/test-event.mjs (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
components/freshchat/actions/list-channels/list-channels.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/freshchat/actions/update-conversation-status/update-conversation-status.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/freshchat/actions/list-agents/list-agents.mjs (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/freshchat/actions/fetch-conversation-details/fetch-conversation-details.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/freshchat/sources/new-message-received/new-message-received.mjs (5)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The `processTimerEvent` method in the `components/salesforce_rest_api/sources/common.mjs` file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/freshchat/sources/new-conversation-started/new-conversation-started.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/freshchat/actions/send-message-in-chat/send-message-in-chat.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/freshchat/freshchat.app.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: The Salesloft API list endpoints (listPeople, listCadences, listUsers, listAccounts) return arrays directly in the response body, not wrapped in a metadata object with a nested data property. The _makeRequest method correctly returns response.data which contains the arrays that can be mapped over directly in propDefinitions.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (19)
components/freshchat/package.json (2)
3-3: LGTM! Appropriate version bump for new integration.The version bump from 0.0.1 to 0.1.0 correctly reflects a minor release introducing new Freshchat integration features.
15-17: LGTM! Proper platform dependency addition.The addition of "@pipedream/platform" dependency is appropriate for the new Freshchat components that use platform utilities like
DEFAULT_POLLING_SOURCE_TIMER_INTERVALandConfigurationError.components/freshchat/sources/new-message-received/test-event.mjs (1)
1-26: LGTM! Comprehensive test event structure.The test event provides a realistic and complete representation of a Freshchat message received event with all necessary fields including message content, IDs, timestamps, and bot-related flags.
components/freshchat/sources/common/base.mjs (2)
18-20: LGTM! Proper abstract method implementation.The
processEventsmethod correctly throws aConfigurationErrorto enforce implementation in subclasses, following the established pattern for abstract methods in Pipedream components.
23-25: LGTM! Appropriate deploy hook implementation.The deploy hook calls
processEvents(25)which is a common pattern for initializing source components with a limited batch size during deployment.components/freshchat/sources/new-conversation-started/test-event.mjs (1)
1-16: LGTM! Well-structured conversation test event.The test event provides a comprehensive representation of a new conversation started event with appropriate fields including conversation IDs, status, properties, and timestamps.
components/freshchat/actions/list-channels/list-channels.mjs (2)
25-35: LGTM! Proper paginated API implementation.The paginated results pattern is correctly implemented with appropriate resource key and parameter handling.
36-38: LGTM! Correct summary message format.The summary message follows the proper format with singular/plural handling, consistent with Pipedream action patterns.
components/freshchat/actions/update-conversation-status/update-conversation-status.mjs (2)
47-50: LGTM! Good validation logic.The validation properly enforces that
agentIdis required when status is "assigned" and throws an appropriateConfigurationError.
60-60: LGTM! Summary message format is correct.The summary message follows the proper format as per the retrieved learnings.
components/freshchat/sources/new-message-received/new-message-received.mjs (2)
32-37: LGTM! Good database persistence pattern.The methods for getting and setting the last created time follow proper database persistence patterns for deduplication.
38-44: LGTM! Good metadata generation.The metadata generation properly creates unique IDs, descriptive summaries, and timestamps from the message data.
components/freshchat/actions/send-message-in-chat/send-message-in-chat.mjs (2)
45-60: Verify the silent error handling approach.The try-catch block silently catches all errors, which could hide important issues. While the comment suggests the API always returns an error even on success, this approach might mask legitimate failures.
Consider logging the error or handling specific error types:
try { await this.freshchat.sendMessageInChat({ $, conversationId: this.conversationId, data, }); - } catch { + } catch (error) { + console.log("Expected API error:", error); // Sends message, but always returns the error
61-62: LGTM! Summary message format is correct.The summary message follows the proper format as per the retrieved learnings.
components/freshchat/actions/list-agents/list-agents.mjs (2)
19-34: LGTM! Comprehensive filtering options.The filtering options for deactivation status and availability status are well-defined and follow proper Pipedream prop patterns.
57-59: LGTM! Excellent summary message format.The summary message properly handles singular/plural forms and follows the correct format as per the retrieved learnings.
components/freshchat/actions/fetch-conversation-details/fetch-conversation-details.mjs (1)
31-31: LGTM! Summary message format is correct.The summary message follows the proper format as per the retrieved learnings.
components/freshchat/sources/new-conversation-started/new-conversation-started.mjs (1)
58-63: The extra API call is required; listConversations only returns minimal fields (includingid) and does not provide the fullconversation_idorcreated_timevalues needed bygenerateMeta, which relies on the detailed conversation object returned fromgetConversation. No changes needed here.components/freshchat/freshchat.app.mjs (1)
228-230: Freshchat pagination handling is correct
The Freshchat API omits thepagination(andlinks) object when there’s only one page of results, so falling back tohasMore = falsewhenresponse.paginationis undefined aligns with the official behavior. No changes needed.
components/freshchat/actions/send-message-in-chat/send-message-in-chat.mjs
Show resolved
Hide resolved
components/freshchat/sources/new-conversation-started/new-conversation-started.mjs
Show resolved
Hide resolved
jcortes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927 lgtm! Ready for QA!
Resolves #17428
Summary by CodeRabbit
New Features
Enhancements
Chores