Origin/17396 fix #17632
Origin/17396 fix #17632
Conversation
This reverts commit 11e0ed2.
# Conflicts: # pnpm-lock.yaml
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update primarily introduces minor formatting improvements by adding newline characters at the end of many Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ApifyComponent
participant ApifyAPI
User->>ApifyComponent: Triggers action (e.g., run-actor)
ApifyComponent->>ApifyAPI: Sends request with headers (including x-apify-integration-platform)
ApifyAPI-->>ApifyComponent: Returns response
ApifyComponent-->>User: Outputs result (with updated version/capitalization)
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/accuweather/accuweather.app.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/alt_text_generator_ai/alt_text_generator_ai.app.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/capturekit/capturekit.app.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (8)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (2)
components/vincario/vincario.app.mjs (1)
6-9: Auth keys are dumped to console – potential credential leak
console.log(Object.keys(this.$auth));will print the names of all auth fields every timeauthKeys()runs.
In production logs this can expose sensitive metadata (or, if the object is stringified elsewhere, actual secrets).- authKeys() { - console.log(Object.keys(this.$auth)); - }, + authKeys() { + // Avoid leaking credential field names in logs + this.$logger.debug("Auth keys retrieved"); // or remove entirely + return Object.keys(this.$auth); + },Consider removing the log or using your framework’s sanitized logger.
components/apify/sources/common/base.mjs (1)
43-44: Typo in fallback ID causes duplicate/undefined keys
createAtshould becreatedAt; current typo will yield"undefined"in the ID and can break deduplication.- id: body.eventData.actorRunId || `${body.userId}-${body.createAt}`, + id: body.eventData.actorRunId || `${body.userId}-${body.createdAt}`,
🧹 Nitpick comments (3)
components/apify/package.json (1)
3-17: Pin or widen? — double-check the new dependency specAdding
@apify/constsis fine, but the caret range^2.41.0allows any 2.x.x update. If an un-tested minor release introduces breaking changes, your sources could mis-parse event payloads. Consider either:- "@apify/consts": "^2.41.0", + "@apify/consts": "2.41.0",or automating Dependabot to surface updates.
components/apify/sources/new-finished-actor-run-instant/new-finished-actor-run-instant.mjs (1)
30-31: Ensurebody.eventData.actorRunIdactually existsThe Apify webhook sometimes nests run IDs under
resource.id(ordata.id) depending on event type. IfactorRunIdis undefined, the summary will read “A new Actor run undefined has finished”. Please confirm the payload shape or guard against missing fields, e.g.:- return `A new Actor run ${body.eventData.actorRunId} has finished`; + const id = body?.eventData?.actorRunId ?? body?.resource?.id ?? "unknown"; + return `A new Actor run ${id} has finished`;components/apify/sources/common/base.mjs (1)
19-23: Consider registering theTESTevent type as wellApify fires a
TESTevent immediately after creating a webhook; omitting it fromeventTypesmeans that test will be delivered even though it isn’t whitelisted, producing a 410 from Apify and cluttering logs.WEBHOOK_EVENT_TYPES.ACTOR_RUN_ABORTED, + WEBHOOK_EVENT_TYPES.TEST,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (27)
components/adtraction/adtraction.app.mjs(1 hunks)components/apify/README.md(1 hunks)components/apify/actions/get-dataset-items/get-dataset-items.mjs(1 hunks)components/apify/actions/run-actor/run-actor.mjs(4 hunks)components/apify/actions/run-task-synchronously/run-task-synchronously.mjs(1 hunks)components/apify/actions/scrape-single-url/scrape-single-url.mjs(1 hunks)components/apify/actions/set-key-value-store-record/set-key-value-store-record.mjs(1 hunks)components/apify/apify.app.mjs(2 hunks)components/apify/package.json(2 hunks)components/apify/sources/common/base.mjs(3 hunks)components/apify/sources/new-finished-actor-run-instant/new-finished-actor-run-instant.mjs(2 hunks)components/apify/sources/new-finished-task-run-instant/new-finished-task-run-instant.mjs(1 hunks)components/asters/asters.app.mjs(1 hunks)components/bitget/bitget.app.mjs(1 hunks)components/explorium/explorium.app.mjs(1 hunks)components/joggai/joggai.app.mjs(1 hunks)components/mumble/mumble.app.mjs(1 hunks)components/neetoform/neetoform.app.mjs(1 hunks)components/order_sender/order_sender.app.mjs(1 hunks)components/pinghome/pinghome.app.mjs(1 hunks)components/prepr_graphql/prepr_graphql.app.mjs(1 hunks)components/prodatakey/prodatakey.app.mjs(1 hunks)components/salesforge/salesforge.app.mjs(1 hunks)components/sign_plus/sign_plus.app.mjs(1 hunks)components/themarketer/themarketer.app.mjs(1 hunks)components/vincario/vincario.app.mjs(1 hunks)components/zenedu/zenedu.app.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
components/apify/package.json (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
components/apify/sources/new-finished-actor-run-instant/new-finished-actor-run-instant.mjs (4)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/apify/sources/common/base.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/apify/actions/run-actor/run-actor.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/column-value-updated/column-value-updated.mjs:17-24
Timestamp: 2025-01-23T03:55:51.998Z
Learning: Alert props in Pipedream components are a special case that do not require a label property, and use the 'content' property as a replacement for description.
Learnt from: js07
PR: PipedreamHQ/pipedream#17375
File: components/zerobounce/actions/get-validation-results-file/get-validation-results-file.mjs:23-27
Timestamp: 2025-07-01T17:07:48.193Z
Learning: "dir" props in Pipedream components are hidden in the component form and not user-facing, so they don't require labels or descriptions for user clarity.
🔇 Additional comments (29)
components/pinghome/pinghome.app.mjs (1)
11-11: Added trailing newline – good practiceEnsures POSIX-style EOF handling and avoids diff noise in future edits.
components/adtraction/adtraction.app.mjs (1)
11-11: Added trailing newline – good practiceKeeps file formatting consistent across the repo.
components/joggai/joggai.app.mjs (1)
11-11: Added trailing newline – good practiceMaintains uniform style; no further action needed.
components/prodatakey/prodatakey.app.mjs (1)
11-11: Added trailing newline – good practicePrevents unnecessary diffs from editors that auto-insert newlines.
components/order_sender/order_sender.app.mjs (1)
11-11: Added trailing newline – good practiceConsistent formatting update acknowledged.
components/asters/asters.app.mjs (1)
11-11: 👍 Formatting-only change acknowledgedOnly a trailing newline was added. No functional impact.
components/bitget/bitget.app.mjs (1)
11-11: 👍 Formatting-only change acknowledgedLooks good—newline at EOF keeps POSIX tools happy.
components/zenedu/zenedu.app.mjs (1)
11-11: 👍 EOF newline addition acceptedNo code behavior changes.
components/prepr_graphql/prepr_graphql.app.mjs (1)
11-11: 👍 Consistent EOF newlineChange is purely stylistic; all good.
components/explorium/explorium.app.mjs (1)
11-11: 👍 Newline addition confirmedNo concerns.
components/mumble/mumble.app.mjs (1)
11-12: Trailing newline added – looks goodThe added newline complies with POSIX conventions and helps avoid unnecessary diff noise. No other changes introduced.
components/sign_plus/sign_plus.app.mjs (1)
11-12: Trailing newline added – looks goodConsistent formatting improvement; nothing functionally altered.
components/salesforge/salesforge.app.mjs (1)
11-12: Trailing newline added – looks goodMaintains consistency across files and adheres to best practices.
components/neetoform/neetoform.app.mjs (1)
11-12: Trailing newline added – looks goodPure formatting change; no concerns.
components/themarketer/themarketer.app.mjs (1)
11-12: Trailing newline added – looks goodChange aligns with coding standards; all set.
components/vincario/vincario.app.mjs (1)
11-12: Trailing newline added – all goodAdding a final newline keeps the file POSIX-compliant and prevents some tooling warnings. No further action needed.
components/apify/README.md (1)
9-9: Consistent capitalization — looks goodChanging “Apify actor” → “Apify Actor” aligns the docs with the branding used across the updated components.
components/apify/sources/new-finished-actor-run-instant/new-finished-actor-run-instant.mjs (1)
8-9: Metadata update LGTMDescription wording and version bump are straightforward.
components/apify/actions/run-task-synchronously/run-task-synchronously.mjs (1)
7-7: Version bump acknowledgedNo functional changes detected; version
0.0.3aligns with other action bumps.components/apify/actions/get-dataset-items/get-dataset-items.mjs (1)
8-8: Version bump acknowledgedBumping to
0.0.3keeps the action in sync with the package update.components/apify/sources/new-finished-task-run-instant/new-finished-task-run-instant.mjs (1)
9-9: LGTM: Standard version incrementThe version bump from "0.0.3" to "0.0.4" aligns with the coordinated version updates across the Apify component ecosystem.
components/apify/actions/set-key-value-store-record/set-key-value-store-record.mjs (1)
8-8: LGTM: Standard version incrementThe version bump from "0.0.3" to "0.0.4" is consistent with the coordinated version updates across the Apify actions.
components/apify/actions/scrape-single-url/scrape-single-url.mjs (1)
8-8: LGTM: Standard version incrementThe version bump from "0.0.3" to "0.0.4" is consistent with the coordinated version updates across the Apify actions.
components/apify/actions/run-actor/run-actor.mjs (2)
10-10: LGTM: Standard version incrementThe version bump from "0.0.3" to "0.0.4" is consistent with the coordinated version updates across the Apify actions.
9-9: LGTM: Improved capitalization consistencyThe capitalization changes from "actor" to "Actor" improve brand consistency and follow proper noun capitalization for the Apify Actor term across user-facing text.
Also applies to: 33-33, 165-165, 244-245
components/apify/apify.app.mjs (2)
52-52: LGTM: Improved capitalization consistencyThe capitalization change from "actor" to "Actor" improves brand consistency and follows proper noun capitalization for the Apify Actor term.
165-165: LGTM: Added platform identification headerThe addition of the
x-apify-integration-platformheader provides useful platform identification for analytics/tracking purposes without affecting functionality.components/apify/sources/common/base.mjs (2)
1-1: Ensure the new dependency is pinned and published before merge
@apify/constsis now a runtime dependency. Double-checkcomponents/apify/package.json(or the workspace root) declares it and pins to the same major version you tested against. Otherwise the build may break on older runners.
40-40: Constant-based check looks goodReplacing the string literal with
WEBHOOK_EVENT_TYPES.TESTkeeps the comparison type-safe and resilient to future renames. 👍
WHY
Summary by CodeRabbit