-
Notifications
You must be signed in to change notification settings - Fork 5.5k
remove withLabel from playlistId #17849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove withLabel from playlistId #17849
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
@tkalejaiye is attempting to deploy a commit to the Pipedreamers Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes update the Spotify "Get a Playlist" action to use the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
WHY
The current Get Playlist Action doesn't work unless a playlist is selected via async options.
Current Behavior:
When a playlist ID is entered via a custom expression or variable, an undefined value gets passed for the playlist ID resulting in a 400 error.
Expected Behavior:
Passing a variable from a previous step or entering a custom expression should function the same as selecting from a dropdown, and properly pass the playlist ID in the API call
Solution:
This PR fixes this by removing a
withLabelparameter in the playlistID prop definition and passingplaylistIdrather thanplaylistId.valuein get-playlist.mjs.I couldn't find reference to it on the docs, but I suspect when
withLabelis set to true, it passes the label of the option along with the value, hence the previous structure of the function in get-playlist.mjs. By removing both, we can now pass playlist IDs by dropdown or custom expression successfullySummary by CodeRabbit