Update Baseurl for the production #17961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
@siddhartha10-krispcall is attempting to deploy a commit to the Pipedreamers Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe change updates the base URL for API requests in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (9)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/krispcall/krispcall.app.mjs (1)
80-82: Clean up outdated dev-URL commentThe commented dev URL references
qa.safefamilyapp.com, a different product.
For clarity, either update it to KrispCall’s actual staging endpoint or drop the line altogether:-// Base URL for Development -// return "https://qa.safefamilyapp.com/api/v3/platform/pipedream"; +// Base URL for Staging / QA (uncomment when needed) +// return "https://qa.krispcall.com/api/v3/platform/pipedream";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/krispcall/krispcall.app.mjs(1 hunks)
🔇 Additional comments (1)
components/krispcall/krispcall.app.mjs (1)
76-79: Verify the new production base URL is reachable and whitelistedThe hard-coded host has been switched from
automationapi.krispcall.comtoapp.krispcall.com.
Before merging, please confirm:
app.krispcall.com/api/v3/platform/pipedreamis live and accepts the same endpoints.- Any API-key, CORS, or IP-allowlist rules have been updated to include Pipedream’s egress IPs hitting the new domain.
- No other components in the repo still point to the old host (quick ripgrep check below).
#!/bin/bash # Search for lingering references to the old production host rg 'automationapi\.krispcall\.com'
michelle0927
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17943
The current url for the production is invalid thus updated a new url.
Summary by CodeRabbit
Summary by CodeRabbit