-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Hubspot - new components #18018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hubspot - new components #18018
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (65)
Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
jcortes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927 lgtm! I've just left a comment other than that it is ready for QA!
| } | ||
| hasMore = paging?.next.after; | ||
| params.after = paging?.next.after; | ||
| } while (hasMore && count < this.maxResults); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe pagination can be reused right?
|
@michelle0927 , thanks. a lot for adding these ! I noticed you added mostly the "Listing" actions, while there is potential for: Duplicate/create a form Would that be something you can help with ? Created #18029 for this |
Resolves #17844