-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Fixing relative import apps #18159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing relative import apps #18159
Changes from 10 commits
95a2687
d0aba59
cddef10
9e2318a
cc545ae
7f0fbba
9aed22b
fff14f8
6adc949
50b6381
cc6ad80
59c5a67
cbce594
dfcc726
d7fce20
ea0db15
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import app from "../../gitlab_developer_app.app.mjs"; | ||
| import common from "../../../gitlab/actions/create-epic/create-epic.mjs"; | ||
| import common from "@pipedream/gitlab/actions/create-epic/create-epic.mjs"; | ||
| import { adjustPropDefinitions } from "../../common/utils.mjs"; | ||
|
|
||
| const { | ||
|
|
@@ -10,7 +10,7 @@ const props = adjustPropDefinitions(others.props, app); | |
| export default { | ||
| ...others, | ||
| key: "gitlab_developer_app-create-epic", | ||
| version: "0.0.1", | ||
| version: "0.0.2", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainVersion bump looks good; confirm consistency across related wrappers and package.json Patch bump to
Run: 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Action versions under gitlab_developer_app:"
rg -nP 'key:\s*"gitlab_developer_app-[^"]+"' -C2 components/gitlab_developer_app/actions \
| rg -n 'version:\s*"[^"]+"' -n || true
echo -e "\nPackage version and gitlab dep:"
fd -a package.json components/gitlab_developer_app \
| xargs -I{} jq -r '.name, .version, .dependencies["@pipedream/gitlab"] // "MISSING"' {}
echo -e "\nRepo-wide stray relative imports to gitlab (belt-and-suspenders):"
rg -nP '\.\./\.\./\.\./gitlab/' components || trueLength of output: 1679 Please align the I checked all GitLab Developer App action versions in
Package metadata looks correct:
No stray relative imports to Action needed:
🤖 Prompt for AI Agents |
||
| name, | ||
| description, | ||
| type, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "@pipedream/gitlab_developer_app", | ||
| "version": "0.1.1", | ||
| "version": "0.1.2", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainVersion bump and new @pipedream/gitlab dependency are appropriate. This directly supports the switch to package-scoped imports.
Also applies to: 15-17 🏁 Script executed: #!/bin/bash
set -euo pipefail
# Validate this package in isolation
npm run validate:package -- @pipedream/gitlab_developer_app || exit 1
# Grep for any remaining relative imports referencing legacy gitlab paths
rg -nP '\.\./\.\./\.\./gitlab/' components/gitlab_developer_app || trueLength of output: 79363 Fix missing dependency to satisfy import validation Version bump to 0.1.2 and the switch to
🤖 Prompt for AI Agents |
||
| "description": "Pipedream GitLab (Developer App) Components", | ||
| "main": "gitlab_developer_app.app.mjs", | ||
| "keywords": [ | ||
|
|
@@ -12,7 +12,8 @@ | |
| "dependencies": { | ||
| "@pipedream/platform": "^1.6.4", | ||
| "lodash": "^4.17.21", | ||
| "uuid": "^8.3.2" | ||
| "uuid": "^8.3.2", | ||
| "@pipedream/gitlab": "^0.5.6" | ||
| }, | ||
| "publishConfig": { | ||
| "access": "public" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Patch version bump looks good; aligns with a non-functional change.
Since this PR’s goal is to remove relative app imports across packages, it’s fine that this file only bumps the action version. Please double-check that the amazon_ses package-level changes are consistent (package.json version bumped, dependency on @pipedream/aws added, and no remaining relative app imports within this package).
Run these quick checks:
🏁 Script executed:
Length of output: 675
🏁 Script executed:
Length of output: 1287
🏁 Script executed:
Length of output: 434
🏁 Script executed:
Length of output: 199
Remove remaining relative app import in
actions/common/base.mjsPatch version bumps and dependency updates look correct, but there’s still one residual relative import of the app module in this package. Please update it to use the published package entrypoint:
components/amazon_ses/actions/common/base.mjsLine 1
Replace:
Once that’s updated, you’ll have:
version.app.mjsimportscomponents/amazon_ses/package.jsonat version0.3.8@pipedream/awslisted underdependencies🤖 Prompt for AI Agents