Skip to content

Conversation

@vunguyenhung
Copy link
Collaborator

@vunguyenhung vunguyenhung commented Aug 26, 2025

Summary by CodeRabbit

  • Documentation
    • Added troubleshooting guidance for when the Connect popup doesn’t open due to Cross-Origin-Opener-Policy in hosting pages; recommends setting COOP to same-origin-allow-popups when appropriate.
    • Inserted info callouts in the quickstart after connectAccount usage and before the interactive demo to highlight the header fix.
    • Updated troubleshooting flows with a new subsection and cross-references; no runtime or API changes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 26, 2025

Walkthrough

Documentation updates add guidance to set the Cross-Origin-Opener-Policy header to same-origin-allow-popups when the Connect popup fails to open. Notes were added in the quickstart and troubleshooting pages. No runtime, API, or code changes.

Changes

Cohort / File(s) Summary
Managed Auth Docs
docs-v2/pages/connect/managed-auth/quickstart.mdx, docs-v2/pages/connect/managed-auth/troubleshooting.mdx
Added info/troubleshooting notes about COOP: instruct setting Cross-Origin-Opener-Policy to same-origin-allow-popups when the Connect popup doesn’t open. Notes placed after connectAccount usage and before the interactive demo, and as a troubleshooting subsection. No functional code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I nudge the docs with gentle hops,
“Set COOP right,” my whiskers props—
same-origin-allow-popups, hooray!
The Connect window springs away.
I thump my foot: support stands by,
Bugs be gone—let popups fly! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/improve-connect-docs-add-popup-not-open-issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vunguyenhung vunguyenhung changed the title Improve connect docs to add solution for the Pipedream Connect popup not opening Improve Pipedream Connect docs to add solution for the Pipedream Connect popup not opening Aug 26, 2025
@vercel
Copy link

vercel bot commented Aug 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
pipedream-docs Ignored Ignored Aug 26, 2025 8:11am
pipedream-docs-redirect-do-not-edit Ignored Ignored Aug 26, 2025 8:11am

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5403da4 and 8f92506.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • docs-v2/pages/connect/managed-auth/quickstart.mdx (1 hunks)
  • docs-v2/pages/connect/managed-auth/troubleshooting.mdx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: pnpm publish
  • GitHub Check: validate-links

vunguyenhung and others added 2 commits August 26, 2025 15:10
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
docs-v2/pages/connect/managed-auth/troubleshooting.mdx (3)

49-53: Add sandbox note and user-activation tip for completeness

Two common, adjacent causes of “popup didn’t open”:

  • The Connect iframe is sandboxed without allowing popups.
  • The popup call isn’t made during a user activation (e.g., not directly in a click handler).

Consider appending this short note after Line 53.

 Set the `Cross-Origin-Opener-Policy` header to `same-origin-allow-popups` on the page that embeds the Connect iframe. The default COOP is `unsafe-none`; only apply this change if you currently send `same-origin`.
+
+If the Connect iframe is sandboxed, ensure the iframe includes `allow="popups"` (and `allow="popups-to-escape-sandbox"` if the popup must navigate outside the sandbox). Also make sure the call that opens the popup runs in direct response to a user action (e.g., inside a click handler), since browsers may block popups without a user activation.

15-16: Standardize casing: “iframe” (per MDN) instead of “iFrame”

Use “iframe” consistently across the page for clarity and consistency.

-which Pipedream validates from the Connect iFrame.
+which Pipedream validates from the Connect iframe.
-from the iFrame in the client.
+from the iframe in the client.

Also applies to: 25-26, 53-53


55-56: Fix minor grammar in the Callout

-If you're still have trouble or hitting an error that isn't listed here, [get in touch with us](https://pipedream.com/support). We'd love to help.
+If you're still having trouble or hitting an error that isn't listed here, [get in touch with us](https://pipedream.com/support). We'd love to help.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8f92506 and 53c7698.

📒 Files selected for processing (2)
  • docs-v2/pages/connect/managed-auth/quickstart.mdx (1 hunks)
  • docs-v2/pages/connect/managed-auth/troubleshooting.mdx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs-v2/pages/connect/managed-auth/quickstart.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Lint Code Base
  • GitHub Check: validate-links
  • GitHub Check: pnpm publish
🔇 Additional comments (1)
docs-v2/pages/connect/managed-auth/troubleshooting.mdx (1)

49-53: COOP guidance is precise and helpful — nice update

The wording correctly calls out COOP: same-origin as the cause and prescribes same-origin-allow-popups on the embedding page. This addresses prior feedback and should reduce confusion.

Copy link
Collaborator

@dannyroosevelt dannyroosevelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops the docs now live in a different repo, I DM'd you the details.

@github-project-automation github-project-automation bot moved this from Ready for PR Review to Done in Component (Source and Action) Backlog Aug 27, 2025
@vunguyenhung vunguyenhung deleted the chore/improve-connect-docs-add-popup-not-open-issue branch August 27, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants