-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Improve Pipedream Connect docs to add solution for the Pipedream Connect popup not opening #18179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Pipedream Connect docs to add solution for the Pipedream Connect popup not opening #18179
Conversation
WalkthroughDocumentation updates add guidance to set the Cross-Origin-Opener-Policy header to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
docs-v2/pages/connect/managed-auth/quickstart.mdx(1 hunks)docs-v2/pages/connect/managed-auth/troubleshooting.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: pnpm publish
- GitHub Check: validate-links
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docs-v2/pages/connect/managed-auth/troubleshooting.mdx (3)
49-53: Add sandbox note and user-activation tip for completenessTwo common, adjacent causes of “popup didn’t open”:
- The Connect iframe is sandboxed without allowing popups.
- The popup call isn’t made during a user activation (e.g., not directly in a click handler).
Consider appending this short note after Line 53.
Set the `Cross-Origin-Opener-Policy` header to `same-origin-allow-popups` on the page that embeds the Connect iframe. The default COOP is `unsafe-none`; only apply this change if you currently send `same-origin`. + +If the Connect iframe is sandboxed, ensure the iframe includes `allow="popups"` (and `allow="popups-to-escape-sandbox"` if the popup must navigate outside the sandbox). Also make sure the call that opens the popup runs in direct response to a user action (e.g., inside a click handler), since browsers may block popups without a user activation.
15-16: Standardize casing: “iframe” (per MDN) instead of “iFrame”Use “iframe” consistently across the page for clarity and consistency.
-which Pipedream validates from the Connect iFrame. +which Pipedream validates from the Connect iframe.-from the iFrame in the client. +from the iframe in the client.Also applies to: 25-26, 53-53
55-56: Fix minor grammar in the Callout-If you're still have trouble or hitting an error that isn't listed here, [get in touch with us](https://pipedream.com/support). We'd love to help. +If you're still having trouble or hitting an error that isn't listed here, [get in touch with us](https://pipedream.com/support). We'd love to help.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
docs-v2/pages/connect/managed-auth/quickstart.mdx(1 hunks)docs-v2/pages/connect/managed-auth/troubleshooting.mdx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- docs-v2/pages/connect/managed-auth/quickstart.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Lint Code Base
- GitHub Check: validate-links
- GitHub Check: pnpm publish
🔇 Additional comments (1)
docs-v2/pages/connect/managed-auth/troubleshooting.mdx (1)
49-53: COOP guidance is precise and helpful — nice updateThe wording correctly calls out COOP: same-origin as the cause and prescribes same-origin-allow-popups on the embedding page. This addresses prior feedback and should reduce confusion.
dannyroosevelt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops the docs now live in a different repo, I DM'd you the details.
Summary by CodeRabbit