Issue 18484 #18485
Merged
Issue 18484 #18485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughVersion increments across Salesforce REST API package and multiple sources. Introduces skip-first-run behavior: guards initial historical emissions in common-updated-record deploy hook and early-exit logic for timer-driven runs in common.mjs. Adds a new boolean prop skipFirstRun to record-updated-instant. No other functional changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User as User
participant Src as Source (record-updated-instant)
participant Common as Common Logic
participant SF as Salesforce API
participant Store as State Storage
participant Timer as Timer
participant Hook as Webhook
User->>Src: Activate with skipFirstRun=[true|false]
alt Webhook-enabled
Note over Src,Hook: Webhook path unchanged
Hook-->>Src: Update event
Src->>Common: process update
Common->>SF: Fetch details
SF-->>Common: Data
Common->>Store: Update cursor/metadata
Common-->>Src: Emit event
else Timer-based polling
Timer-->>Src: Tick
Src->>Common: run(event=timer)
alt First run AND skipFirstRun=true
Common->>Store: Initialize latest timestamp = now
Common-->>Src: Exit (no emit)
else Subsequent runs or skipFirstRun=false
Common->>Store: Read last timestamp
Common->>SF: Query updates since cursor
SF-->>Common: Records
Common->>Store: Update cursor
Common-->>Src: Emit events
end
end
sequenceDiagram
autonumber
participant Src as Source (updated-record variants)
participant Deploy as deploy()
participant SF as Salesforce API
participant Store as State Storage
Deploy->>Src: On activation
alt skipFirstRun=true
Note over Src: Historical backfill skipped
Deploy-->>Src: Complete without emits
else skipFirstRun=false
Src->>SF: List recent items
SF-->>Src: Recent items
loop last 25 items
Src->>Store: Generate metadata
Src-->>Deploy: Emit historical event
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (13)
🧰 Additional context used🧠 Learnings (3)📚 Learning: 2024-10-08T15:33:38.240ZApplied to files:
📚 Learning: 2024-10-10T19:18:27.998ZApplied to files:
📚 Learning: 2024-07-24T02:05:59.531ZApplied to files:
🧬 Code graph analysis (2)components/salesforce_rest_api/sources/common/common-updated-record.mjs (2)
components/salesforce_rest_api/sources/common/common.mjs (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
vunguyenhung
moved this from Ready for QA
to In QA
in Component (Source and Action) Backlog
vunguyenhung
moved this from In QA
to Ready for QA
in Component (Source and Action) Backlog
vunguyenhung
moved this from Ready for QA
to In QA
in Component (Source and Action) Backlog
vunguyenhung
moved this from In QA
to Changes Required
in Component (Source and Action) Backlog
|
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement. Please check the test report below for more information |
choeqq
commented
Sep 30, 2025
There was a problem hiding this comment.
Hi @vunguyenhung I am not quite sure if I made a mistake in setup of this source, but I created exact same trigger (I just changed Lastname to Firstname), I had 6 leads in the list, changed Firstname for one of them and got the event exactly as expected 🤔
And also as expected I didn't get other Leads, on initial call
Just to remind you in case of any misunderstanding:
This trigger should fire only on Record Update, so I don't think that you should even see the events mentioned in notion doc (added Leads), it's supposed to be a change on the fields we're listening to 🙌
michelle0927
moved this from Changes Required
to Ready for QA
in Component (Source and Action) Backlog
vunguyenhung
moved this from Ready for QA
to In QA
in Component (Source and Action) Backlog
vunguyenhung
moved this from In QA
to Ready for QA
in Component (Source and Action) Backlog
vunguyenhung
moved this from Ready for QA
to Ready for Release
in Component (Source and Action) Backlog
|
Hi everyone, all test cases are passed! Ready for release! Test report |
|
Hey @choeqq, thank you for the clarification. I was testing by creating the leads and assume that it will trigger the source. Now I updated the record and it emits event correctly now. Thank you. Release this now |
github-project-automation
bot
moved this from Ready for Release
to Done
in Component (Source and Action) Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
#18484
Summary by CodeRabbit
New Features
Chores