Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@pipedream/types",
"version": "0.3.2",
"version": "0.3.3",
"description": "Pipedream TypeScript types",
"keywords": [
"pipedream",
Expand Down
6 changes: 6 additions & 0 deletions types/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable @typescript-eslint/ban-types */

Check failure on line 1 in types/src/index.ts

View workflow job for this annotation

GitHub Actions / Lint Code Base

Definition for rule '@typescript-eslint/ban-types' was not found
/* eslint-disable @typescript-eslint/no-explicit-any */
export type JSONValue =
| string
Expand Down Expand Up @@ -70,7 +70,7 @@
/**
* Http Body
*/
body: string | Buffer | NodeJS.ReadableStream;

Check failure on line 73 in types/src/index.ts

View workflow job for this annotation

GitHub Actions / Lint Code Base

'NodeJS' is not defined
/**
* If true, issue the response when the promise returned is resolved, otherwise issue
* the response at the end of the workflow execution
Expand Down Expand Up @@ -115,13 +115,13 @@

export interface IFile {
delete(): Promise<void>;
createReadStream(): Promise<NodeJS.ReadableStream>;

Check failure on line 118 in types/src/index.ts

View workflow job for this annotation

GitHub Actions / Lint Code Base

'NodeJS' is not defined
createWriteStream(contentType?: string, contentLength?: number): Promise<NodeJS.WritableStream>;

Check failure on line 119 in types/src/index.ts

View workflow job for this annotation

GitHub Actions / Lint Code Base

'NodeJS' is not defined
toEncodedString(encoding?: string, start?: number, end?: number): Promise<string>;
toUrl(): Promise<string>;
toFile(localFilePath: string): Promise<void>;
toBuffer(): Promise<Buffer>;
fromReadableStream(readableStream: NodeJS.ReadableStream, contentType?: string, contentSize?: number): Promise<IFile>;

Check failure on line 124 in types/src/index.ts

View workflow job for this annotation

GitHub Actions / Lint Code Base

'NodeJS' is not defined
fromFile(localFilePath: string, contentType?: string): Promise<IFile>;
fromUrl(url: string, options?: any): Promise<IFile>;
toJSON(): any;
Expand Down Expand Up @@ -384,6 +384,12 @@
type: "action";
methods?: Methods & ThisType<PropThis<ActionPropDefinitions> & Methods>;
props?: ActionPropDefinitions;
annotations?: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add idempotentHint? while you're at it, even though we aren't backfilling that value for any components right now

destructiveHint?: boolean;
idempotentHint?: boolean;
openWorldHint?: boolean;
readOnlyHint?: boolean;
}
additionalProps?: (
previousPropDefs: ActionPropDefinitions
) => Promise<ActionPropDefinitions>;
Expand Down
Loading