17541 components walletap

[luancazarine]

Resolves #17541

Summary by CodeRabbit

• New Features

  • Create mobile wallet passes with email/phone delivery and locale support.
  • Retrieve pass details by ID.
  • Update passes (fields, member info, validity, redemption value) and push changes to users.
  • Send notifications to pass holders.
  • Improved handling of structured pass data for more robust input parsing.

• Chores

  • WalletAP component bumped to v0.1.0 and dependencies refreshed.

[coderabbitai]

Walkthrough

Adds a Walletap component: an internal HTTP client wrapper with methods for create/get/update pass and send notification, a parseObject utility, four action modules for pass operations and notifications, and package metadata/version bump.

Changes

Cohort / File(s)	Summary
Walletap API wrapper components/walletap/walletap.app.mjs	Replaces authKeys() with _apiUrl(), _getHeaders(), and centralized _makeRequest({ $,... }); adds createPass, getPass, updatePass, and sendNotification methods that use the request pipeline and auth header.
Actions: Create / Get / Update Pass components/walletap/actions/create-pass/create-pass.mjs, components/walletap/actions/get-pass/get-pass.mjs, components/walletap/actions/update-pass/update-pass.mjs	Adds three action modules exporting default action objects (metadata, props, async run); each calls the app wrapper (createPass/getPass/updatePass), normalizes inputs with parseObject where applicable, exports a "$summary", and returns the API response.
Action: Send Notification components/walletap/actions/send-notification/send-notification.mjs	Adds action exporting default object (metadata, props, async run) that calls sendNotification on the app wrapper, exports a success "$summary", and returns the API response.
Utilities components/walletap/common/utils.mjs	Adds export const parseObject(obj) to safely parse JSON strings or arrays of strings (returns undefined for falsy input; falls back to original values on parse errors).
Package metadata components/walletap/package.json	Bumps version 0.0.1 → 0.1.0 and adds dependency "@pipedream/platform": "^3.1.0".

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Runner as Workflow / Action Runner
  participant Action as Walletap Action
  participant App as Walletap App Wrapper
  participant API as WalletAP HTTP API

  Runner->>Action: run(props, $)
  Action->>App: call method (createPass | getPass | updatePass | sendNotification)
  App->>App: _getHeaders()\n_apiUrl()
  App->>API: _makeRequest(path, method, headers, data)
  API-->>App: HTTP response
  App-->>Action: response
  Action-->>Runner: export "$summary" and return response
  note right of App: centralizes HTTP, auth, and error flow

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I tap my paw—new passes bloom,
Small requests hop through headers' room.
Strings get parsed with gentle care,
Calls go out on tidy air.
Version raised — we bound and zoom! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (3 warnings)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title “17541 components walletap” is vague, includes an issue number, and does not succinctly describe the main addition of Walletap action modules.	Rename the title to clearly summarize the change, for example “Add Walletap actions for creating, updating passes and sending notifications”.
Out of Scope Changes Check	⚠️ Warning	The PR introduces a new “get-pass” action and corresponding getPass method that were not requested by issue #17541’s objectives, which only specified create, update, and notification actions.	Remove the get-pass implementation or confirm whether retrieving passes should be in scope for this component addition before merging.
Description Check	⚠️ Warning	The description only contains “Resolves #17541” and does not follow the repository template requiring a “## WHY” section explaining the rationale for the change.	Update the description to follow the template by adding a “## WHY” heading with a clear explanation of why the Walletap components are being introduced.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues Check	✅ Passed	The pull request implements all coding tasks from issue #17541 by adding the Create Pass, Update Pass, and Send Notification actions as specified in the linked issue.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 17541-components-walletap

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd62f8e and 0b699b7.

📒 Files selected for processing (1)

• components/walletap/actions/get-pass/get-pass.mjs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• components/walletap/actions/get-pass/get-pass.mjs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Lint Code Base
• GitHub Check: Publish TypeScript components
• GitHub Check: Verify TypeScript components

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
pipedream-docs	Ignored			Oct 2, 2025 7:32pm
pipedream-docs-redirect-do-not-edit	Ignored			Oct 2, 2025 7:32pm

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

components/walletap/common/utils.mjs (1)

1-24: LGTM! Consider optional logging for parse failures.

The defensive JSON parsing approach is appropriate for handling flexible user input. The fallback behavior (returning the unparsed string on error) prevents runtime exceptions.

Optionally, you could add debug logging to help troubleshoot malformed JSON during development:

         try {
           return JSON.parse(item);
         } catch (e) {
+          // Uncomment for debugging: console.log("Failed to parse item:", item, e.message);
           return item;
         }

Similar logging could be added at line 19 for string parsing.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57c0956 and d07ed52.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (7)

• components/walletap/actions/create-pass/create-pass.mjs (1 hunks)
• components/walletap/actions/get-pass/get-pass.mjs (1 hunks)
• components/walletap/actions/send-notification/send-notification.mjs (1 hunks)
• components/walletap/actions/update-pass/update-pass.mjs (1 hunks)
• components/walletap/common/utils.mjs (1 hunks)
• components/walletap/package.json (2 hunks)
• components/walletap/walletap.app.mjs (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (5)

components/walletap/actions/get-pass/get-pass.mjs (2)

components/walletap/actions/create-pass/create-pass.mjs (1)

• response (55-65)

components/walletap/actions/update-pass/update-pass.mjs (1)

• response (66-78)

components/walletap/actions/send-notification/send-notification.mjs (3)

components/walletap/actions/create-pass/create-pass.mjs (1)

• response (55-65)

components/walletap/actions/get-pass/get-pass.mjs (1)

• response (23-28)

components/walletap/actions/update-pass/update-pass.mjs (1)

• response (66-78)

components/walletap/actions/create-pass/create-pass.mjs (2)

components/walletap/actions/update-pass/update-pass.mjs (1)

• response (66-78)

components/walletap/common/utils.mjs (2)

• parseObject (1-24)
• parseObject (1-24)

components/walletap/walletap.app.mjs (1)

components/spotify/actions/get-album-tracks/get-album-tracks.mjs (1)

• axios (53-56)

components/walletap/actions/update-pass/update-pass.mjs (1)

components/walletap/common/utils.mjs (2)

• parseObject (1-24)
• parseObject (1-24)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Verify TypeScript components
• GitHub Check: Publish TypeScript components
• GitHub Check: Lint Code Base
• GitHub Check: pnpm publish

🔇 Additional comments (4)

components/walletap/walletap.app.mjs (1)

8-51: LGTM!

The API wrapper follows best practices:

• Centralized request handling via _makeRequest
• Proper authentication headers from this.$auth.api_key
• Correct HTTP methods for each operation (POST for create, PATCH for update, etc.)
• Clean separation of concerns with helper methods

components/walletap/actions/send-notification/send-notification.mjs (1)

3-39: LGTM!

The notification action is well-structured with clear props and correct API usage. The implementation follows the established pattern across other Walletap actions.

components/walletap/actions/update-pass/update-pass.mjs (1)

4-83: LGTM!

The update-pass action correctly:

• Uses parseObject to normalize templateFields and customFields (handles both string and object inputs)
• Includes all relevant optional parameters
• Provides clear prop descriptions aligned with the API documentation
• Returns a descriptive summary with the updated pass ID

components/walletap/actions/create-pass/create-pass.mjs (1)

4-70: LGTM!

The create-pass action is well-implemented:

• Uses parseObject to convert the passes string array into structured objects
• Includes comprehensive delivery options (email, phone, locale)
• Provides a helpful example in the prop description showing the expected JSON structure
• Returns a clear summary with the created pass ID

[michelle0927]

LGTM! Ready for QA!