-
Couldn't load subscription status.
- Fork 5.5k
Adding action-annotations ESLint rule #18676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughBatch update: added an Changes
Sequence Diagram(s)(Skipped — changes are metadata-only; no control-flow or new feature to diagram.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
eslint.config.mjs(2 hunks)package.json(1 hunks)
🔇 Additional comments (1)
eslint.config.mjs (1)
219-219: LGTM! Rule configuration is consistent.The
action-annotationsrule is appropriately enabled for action/source files and disabled for common utility files. This configuration aligns well with the existing pipedream rules pattern.Also applies to: 240-240
PR that adds this rule: PipedreamHQ/eslint-plugin-pipedream#15
Note 1: package versions are not being updated as this info is irrelevant when importing the package (it is relevant when the components are used directly as MCP tools). This was the same when mass updating existing components to include the annotations.
Note 2: this can be tested by running
npx eslint components/gmail/actionswhich should succeed with no warnings, then you can remove the annotations object or one of its properties from a gmail action, and the same command should emit an error.Summary by CodeRabbit