Skip to content

Conversation

@michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Oct 8, 2025

Resolves #9073

Summary by CodeRabbit

  • New Features

    • Added actions to list Domains, Keywords, and Brands from AccuRanker.
    • Added searchable dropdowns for Domain ID and Keyword ID that load options dynamically.
    • Added optional date range filters (Period From/To) and a Max results limit.
    • Improved pagination for reliable retrieval of large datasets.
    • Enhanced summaries showing the number of items returned.
  • Chores

    • Bumped component version to 0.7.0.
    • Updated platform dependency for compatibility and stability.

@vercel
Copy link

vercel bot commented Oct 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
pipedream-docs Ignored Ignored Oct 8, 2025 6:03pm
pipedream-docs-redirect-do-not-edit Ignored Ignored Oct 8, 2025 6:03pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Walkthrough

Adds an authenticated HTTP client, paginated request helper, and propDefinitions for domain/keyword selectors and date/max parameters to the AccuRanker app; introduces three new actions (List Domains, List Keywords, List Brands); updates package version and platform dependency.

Changes

Cohort / File(s) Summary
AccuRanker app core
components/accuranker/accuranker.app.mjs
Adds _baseUrl and _makeRequest (axios wrapper with Authorization), enriches propDefinitions with domainId, keywordId, periodFrom, periodTo, and max; adds listDomains, listKeywords, listBrands; implements generic async paginate; removes authKeys.
New actions: listing
components/accuranker/actions/list-domains/list-domains.mjs, components/accuranker/actions/list-keywords/list-keywords.mjs, components/accuranker/actions/list-brands/list-brands.mjs
New action modules that call the app-level paginate with respective list* functions, accept fields/date/max props, aggregate paginated results, and export a summary and results.
Package metadata
components/accuranker/package.json
Bumps version 0.6.00.7.0; updates @pipedream/platform dependency from ^3.0.0^3.1.0.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Action as List Action
  participant App as AccuRanker App
  participant HTTP as _makeRequest
  participant API as AccuRanker API

  User->>Action: invoke (props: fields, periodFrom/To, max, domainId?)
  Action->>App: paginate({ fn: list*, args, max })
  loop pages (until exhausted or max reached)
    App->>HTTP: _makeRequest(path, params, $)
    HTTP->>API: GET /v4/... (Authorization: Bearer token)
    API-->>HTTP: paged response (data, paging)
    HTTP-->>App: data page
    App-->>Action: yield items
  end
  Action->>User: return aggregated results + $summary
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

I hop through pages, nibbling JSON treats,
Domains, keywords, brands in tidy fleets.
A tiny token warms each API call—
I paginate, yield, and stash them all.
Carrots for code! 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description only includes a reference to the issue number and does not follow the repository’s required template, as it lacks the “## WHY” section and any explanation of the change’s purpose or context. Please update the description to include the “## WHY” section from the template and provide details on the motivation, context, and summary of the implemented changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly indicates that the pull request adds new actions for the AccuRanker integration, succinctly summarizing the primary change of introducing list domains, keywords, and brands actions.
Linked Issues Check ✅ Passed The changes introduce the three requested actions—List Domains, List Keywords, and List Brands—and include the necessary application module updates for API access and pagination, fulfilling the coding requirements of issue #9073.
Out of Scope Changes Check ✅ Passed All code changes support the new AccuRanker actions or reflect the required version bump for releasing these features, and no unrelated or out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-9073

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1f83c2 and 617050b.

📒 Files selected for processing (1)
  • components/accuranker/actions/list-keywords/list-keywords.mjs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • components/accuranker/actions/list-keywords/list-keywords.mjs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Lint Code Base
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Publish TypeScript components
  • GitHub Check: pnpm publish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 905ac86 and f1f83c2.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • components/accuranker/accuranker.app.mjs (1 hunks)
  • components/accuranker/actions/list-brands/list-brands.mjs (1 hunks)
  • components/accuranker/actions/list-domains/list-domains.mjs (1 hunks)
  • components/accuranker/actions/list-keywords/list-keywords.mjs (1 hunks)
  • components/accuranker/package.json (2 hunks)
🧰 Additional context used
🧬 Code graph analysis (4)
components/accuranker/actions/list-domains/list-domains.mjs (1)
components/accuranker/accuranker.app.mjs (1)
  • domains (13-19)
components/accuranker/actions/list-brands/list-brands.mjs (2)
components/accuranker/actions/list-domains/list-domains.mjs (1)
  • results (63-63)
components/accuranker/actions/list-keywords/list-keywords.mjs (1)
  • results (70-70)
components/accuranker/actions/list-keywords/list-keywords.mjs (1)
components/accuranker/accuranker.app.mjs (1)
  • keywords (33-40)
components/accuranker/accuranker.app.mjs (3)
components/accuranker/actions/list-domains/list-domains.mjs (2)
  • domains (50-61)
  • results (63-63)
components/accuranker/actions/list-keywords/list-keywords.mjs (2)
  • keywords (56-68)
  • results (70-70)
components/accuranker/actions/list-brands/list-brands.mjs (1)
  • results (66-66)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: pnpm publish
  • GitHub Check: Lint Code Base
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Verify TypeScript components

@vunguyenhung vunguyenhung merged commit d72dbc6 into master Oct 10, 2025
10 checks passed
@vunguyenhung vunguyenhung deleted the issue-9073 branch October 10, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ACTIONS] AccuRanker New Actions

3 participants