Skip to content

Conversation

@michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Oct 16, 2025

Fixes the base URL to reflect a previous change to $auth.

Summary by CodeRabbit

  • Chores
    • Bumped version metadata for multiple Workday actions and a Workday event source to new patch versions.
    • Updated the Workday component package version.
  • Bug Fixes / Configuration
    • Adjusted Workday app base URL resolution to use the configured REST API endpoint for requests.

@michelle0927 michelle0927 self-assigned this Oct 16, 2025
@vercel
Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
pipedream-docs Ignored Ignored Oct 16, 2025 5:14pm
pipedream-docs-redirect-do-not-edit Ignored Ignored Oct 16, 2025 5:14pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Walkthrough

Multiple Workday actions and one source had their exported metadata versions bumped; the Workday app's base URL resolution was changed to use the authenticated rest_api_endpoint instead of composing a URL from domain and tenant_id. Package version also incremented.

Changes

Cohort / File(s) Summary
Workday Action Version Bumps
components/workday/actions/change-business-title/change-business-title.mjs, components/workday/actions/create-job-change/create-job-change.mjs, components/workday/actions/get-worker/get-worker.mjs, components/workday/actions/list-organization-types/list-organization-types.mjs, components/workday/actions/list-supervisory-organizations/list-supervisory-organizations.mjs, components/workday/actions/list-worker-payslips/list-worker-payslips.mjs, components/workday/actions/search-workers/search-workers.mjs
Exported action metadata version updated from 0.0.20.0.3. No logic or control-flow changes aside from one success message using response.descriptor in get-worker.
Workday Source Version Bump
components/workday/sources/new-worker-created/new-worker-created.mjs
Exported source metadata version updated from 0.0.10.0.2. No behavioral changes.
App baseUrl & package
components/workday/workday.app.mjs, components/workday/package.json
_baseUrl now returns this.$auth.rest_api_endpoint (replaces URL built from domain + tenant_id); package version bumped 0.1.00.1.1.

Sequence Diagram(s)

sequenceDiagram
  participant App as workday.app
  participant Auth as Auth Metadata
  participant API as Workday API Client

  rect rgb(240,248,255)
    note right of App: New flow — base URL resolved from auth
    App->>Auth: read rest_api_endpoint
    Auth-->>App: rest_api_endpoint URL
    App->>API: initialize client with baseUrl=rest_api_endpoint
    API-->>App: ready
  end

  rect rgb(255,250,240)
    note right of App: Old flow (for comparison)
    App->>App: compute URL using domain + tenant_id
    App->>API: initialize client with baseUrl=computed URL
    API-->>App: ready
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nudged some numbers, hopped versions up with glee,
Auth gave me pathways, now endpoints rest with me.
Actions and a source took gentle, tiny hops,
A package bumped its tag — then I munched on crops. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description provided ("Fixes the base URL to reflect a previous change to $auth.") is minimal and does not follow the required template structure. The repository template specifies a "## WHY" section that should be completed by the author, but the provided description is only a single line without the template heading or structure. While the description itself is on-topic and explains what was changed, it is largely incomplete compared to the template requirement and lacks the organized context that the template was designed to capture.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "Workday - Update Base URL" clearly identifies the primary functional change in this changeset—specifically, the modification to the base URL resolution in components/workday/workday.app.mjs where _baseUrl now returns this.$auth.rest_api_endpoint instead of constructing a URL from domain and tenant_id. While the pull request also includes version bumps across multiple files, these are supporting/maintenance changes, and the title appropriately focuses on the main functional change. The title is concise, specific, and directly summarizes what a teammate would need to understand about the primary change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch workday-update-base-url

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8ebb6c and 99ba936.

📒 Files selected for processing (1)
  • components/workday/actions/get-worker/get-worker.mjs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • components/workday/actions/get-worker/get-worker.mjs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Ensure component commits modify component versions
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Lint Code Base

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

jcortes
jcortes previously approved these changes Oct 16, 2025
Copy link
Collaborator

@jcortes jcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michelle0927 lgtm! Ready for QA!

@jcortes jcortes moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Oct 16, 2025
Changed the $summary export to display the worker's descriptor (human-readable name) instead of the workerId for better user experience.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@michelle0927 michelle0927 merged commit fe7f45d into master Oct 16, 2025
10 checks passed
@michelle0927 michelle0927 deleted the workday-update-base-url branch October 16, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants