Skip to content

Conversation

choeqq
Copy link
Contributor

@choeqq choeqq commented Oct 17, 2025

WHY

this.webinar is of type number and object.id is of type string hence every comparison failed, which resulted in event being skipped.

Summary by CodeRabbit

  • New Features

    • Released Zoom Admin component version 0.13.0 with updates to multiple event sources including account, meeting, recording, user, and webinar events.
  • Bug Fixes

    • Fixed webinar event filtering to correctly handle type comparisons in event matching.

Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
pipedream-docs-redirect-do-not-edit Ignored Ignored Oct 17, 2025 8:05am

@adolfo-pd adolfo-pd added the User submitted Submitted by a user label Oct 17, 2025
@choeqq choeqq changed the title Fix zoom admin webinar Fix zoom admin webinar ended source - id comparison Oct 17, 2025
@pipedream-component-development
Copy link
Collaborator

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@pipedream-component-development
Copy link
Collaborator

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

Copy link
Contributor

coderabbitai bot commented Oct 17, 2025

Walkthrough

This PR bumps the zoom_admin component version from 0.12.0 to 0.13.0 and updates version metadata across all related source files. Additionally, the webinar-ended source's isRelevant method now casts this.webinar to String for comparison consistency.

Changes

Cohort / File(s) Summary
Package version update
components/zoom_admin/package.json
Component version bumped from 0.12.0 to 0.13.0
Source version 0.1.7 → 0.1.8
components/zoom_admin/sources/account-settings-updated/..., account-updated/..., custom-events/..., meeting-created/..., meeting-deleted/..., meeting-ended/..., meeting-started/..., meeting-updated/..., user-activated/..., user-created/..., user-deactivated/..., user-deleted/..., user-invitation-accepted/..., user-updated/..., webinar-changes-to-panelists/..., webinar-created/..., webinar-deleted/..., webinar-updated/...
Version property bumped from 0.1.7 to 0.1.8 across 18 source modules
Minor version updates
components/zoom_admin/sources/account-created/account-created.mjs, recording-completed/recording-completed.mjs
Version bumped from 0.1.8 to 0.1.9
Patch version update
components/zoom_admin/sources/new-recording-transcript-completed/new-recording-transcript-completed.mjs
Version bumped from 0.0.2 to 0.0.3
Minor version update
components/zoom_admin/sources/webinar-started/webinar-started.mjs
Version bumped from 0.1.9 to 0.1.10
Logic update with version bump
components/zoom_admin/sources/webinar-ended/webinar-ended.mjs
Version bumped from 0.1.7 to 0.1.8; isRelevant method now casts this.webinar to String in comparison: String(this.webinar) instead of this.webinar

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Most changes are homogeneous version bumps with minimal complexity. The one notable change is the type-casting logic in webinar-ended's isRelevant method, which requires verification that String coercion aligns with comparison expectations.

Possibly related PRs

Suggested reviewers

  • michelle0927
  • GTFalcao

Poem

🐰 Versions dance and numbers climb,
Twenty sources bump in time,
Strings are cast to fix the flow,
Webinars now compare just so!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The PR title "Fix zoom admin webinar" references a real aspect of the changeset—specifically the functional type-casting fix in the webinar-ended.mjs file where isRelevant now casts this.webinar to a string. However, the title significantly misrepresents the overall scope of changes. The changeset is dominated by version bumps across 20+ source files (package.json 0.12.0→0.13.0, most sources 0.1.7→0.1.8, and various other increments), yet the title mentions only the webinar fix and does not acknowledge these pervasive version updates. While the functional fix aligns with the PR's stated objective, the title is incomplete as it fails to communicate the full extent of the modifications being merged. Consider revising the title to reflect the full scope of the PR, for example: "Bump Zoom Admin component versions and fix webinar ID type mismatch" or "Update Zoom Admin components: version bumps and webinar event fix." This would clearly communicate both the extensive version updates and the functional fix to reviewers scanning the PR history.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed The PR description includes a complete "WHY" section as specified in the repository's template, explaining the root cause of the issue: this.webinar is a number while object.id is a string, causing comparison failures and events to be skipped. The explanation is specific, informative, and clearly conveys the motivation for the changes. The template only requires the WHY section, which has been properly filled with meaningful content.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michelle0927 michelle0927 moved this from In Review to Ready for QA in Component (Source and Action) Backlog Oct 17, 2025
@michelle0927 michelle0927 merged commit 650445a into PipedreamHQ:master Oct 18, 2025
9 of 10 checks passed
@michelle0927 michelle0927 moved this from Done to Ready for QA in Component (Source and Action) Backlog Oct 18, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to Done in Component (Source and Action) Backlog Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

User submitted Submitted by a user

Development

Successfully merging this pull request may close these issues.

4 participants