-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Fix zoom admin webinar ended source - id comparison #18795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zoom admin webinar ended source - id comparison #18795
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
WalkthroughThis PR bumps the zoom_admin component version from 0.12.0 to 0.13.0 and updates version metadata across all related source files. Additionally, the webinar-ended source's isRelevant method now casts Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Most changes are homogeneous version bumps with minimal complexity. The one notable change is the type-casting logic in webinar-ended's Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
WHY
this.webinar
is of typenumber
andobject.id
is of typestring
hence every comparison failed, which resulted in event being skipped.Summary by CodeRabbit
New Features
Bug Fixes