Skip to content

Conversation

@GTFalcao
Copy link
Collaborator

@GTFalcao GTFalcao commented Oct 20, 2025

Closes #18809

The teamId prop is specifically having issues in Pipedream MCP, and I believe it is due to the format (sending an array in the propDefinition's third arg).

Since this format is very unusual and there is no need for it at all (getTeams already wraps the incoming value in an array if it is not one), I'm changing it to the standard format widely used across components.

Summary by CodeRabbit

  • New Features

    • Simplified team/workspace parameter handling in the Create Project action for streamlined configuration.
  • Chores

    • Bumped component version to 0.8.1.

@vercel
Copy link

vercel bot commented Oct 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
pipedream-docs Ignored Ignored Oct 20, 2025 5:34pm
pipedream-docs-redirect-do-not-edit Ignored Ignored Oct 20, 2025 5:34pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025

Walkthrough

Updated the Asana Team propDefinition to return a single workspace value instead of a wrapped workspaces array. Correspondingly updated the teams options method to destructure workspace directly. Bumped package version from 0.8.0 to 0.8.1.

Changes

Cohort / File(s) Summary
Team workspace parameter simplification
components/asana/actions/create-project/create-project.mjs, components/asana/asana.app.mjs
Updated Team propDefinition to return { workspace } instead of { workspaces: [workspace] }. Updated corresponding teams.options() method signature to destructure single workspace parameter.
Version bump
components/asana/package.json
Incremented version from 0.8.0 to 0.8.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A workspace unwrapped, array cast away,
Simpler shapes guide the Asana today,
From nested arrays to a cleaner design,
Version bumped—this refactor feels fine! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Asana 'Create Project' fix" clearly relates to the changeset, which focuses on fixing the Create Project action in the Asana component by correcting the team propDefinition format. The title correctly identifies the specific action being fixed and communicates that a bug fix was made. While the title doesn't specify the technical nature of the fix (the workspace/team format change), it appropriately conveys the main change at a high level, which is expected in PR titles. A teammate scanning the repository history would understand that this addresses an issue with the Create Project functionality.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The PR description provides clear and specific reasoning for the changes, explaining that the teamId prop has issues in Pipedream MCP due to an unusual array format in the propDefinition, and that this format is unnecessary since getTeams already handles wrapping values. However, the description does not include the "## WHY" section heading specified in the repository's template; instead, the rationale is provided in narrative form. Despite the missing section header, the description is substantive, on-topic, and addresses the core purpose of explaining why the changes are needed.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch asana-create-project-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vunguyenhung vunguyenhung merged commit 0908b4c into master Oct 22, 2025
9 of 10 checks passed
@vunguyenhung vunguyenhung deleted the asana-create-project-fix branch October 22, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Asana Create Project fails in MCP

3 participants