fullscreen bars as overlay on desktop browsers. #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On desktop browsers the bars in fullscreen mode (caption at the bottom and buttons at the top) are not shown as overlays at the moment. For this reason images are not shown edge to edge of the screen. Images are smaller with black bars on top and bottom
In my opinion you get a better viewing experience when the images take up the whole screen.
See screenshot examples in my issue #252.
This can be achieved when setting the barsSize for top and bottom to zero.
I had to add the line between a
{literal}block because of the curly braces of the barsSize property.