Skip to content

remove xray version check #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove xray version check #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions pkg/xray/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,22 +157,12 @@ func (p *XrayProvider) Configure(ctx context.Context, req provider.ConfigureRequ
)
}

version, err := util.GetXrayVersion(restyClient)
if err != nil {
resp.Diagnostics.AddError(
"Error getting Xray version",
err.Error(),
)
return
}

featureUsage := fmt.Sprintf("Terraform/%s", req.TerraformVersion)
go util.SendUsage(ctx, restyClient.R(), productId, featureUsage)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could drop the telemetry too if we really need to keep this fork around. 😄

Copy link
Author

@aliculPix4D aliculPix4D Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I noticed this immediately yesterday. Its just a post request towards our Artifactory:
https://github.com/jfrog/terraform-provider-shared/blob/55f41af49bcfba33502066064ac468c09563340c/util/util.go#L64C9-L64C37

The Artifactory REST API endpoint artifactory/api/system/usage provides information about the system's usage, including resource consumption. This endpoint is useful for monitoring and understanding how Artifactory is being utilized.


meta := util.ProviderMetadata{
Client: restyClient,
ProductId: productId,
XrayVersion: version,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this really didn't seems to be used for anything except reporting metadata.

Client: restyClient,
ProductId: productId,
}

p.Meta = meta
Expand Down