Open
Conversation
This adds the PhysicalCameraExposure and PhysicalCameraSensorSensitivity schema. Both are single-apply schema intended to be applied to a PhysicalCamera or UsdGeomCamera. Exposure adds iso, shutter speed etc, and SensorSensitivity adds spectral sensitivity curves in the spirit of Wetas physLight
add schema for exposure and sensitivity
- Rename Sensitivity to Responsivity per latest lingo - Include RGB in camera responsivity schema name to indicate it's an RGB camera rather than something else
updates based on WG discussion
meshula
commented
Mar 20, 2024
meshula
commented
Mar 20, 2024
meshula
commented
Mar 20, 2024
meshula
commented
Mar 20, 2024
meshula
commented
Mar 20, 2024
meshula
commented
Mar 20, 2024
| float2 aperture = (36.0, 24.0) ( | ||
| doc = '''aperture in millimeters''' | ||
| ) | ||
| float handedness = 1.0 ( |
Contributor
There was a problem hiding this comment.
Why a float type for this value?
Member
Author
There was a problem hiding this comment.
That follows GfMatrix where we see
/// Returns the sign of the determinant of the matrix, i.e. 1 for a
/// right-handed matrix, -1 for a left-handed matrix, and 0 for a
/// singular matrix.
GF_API
double GetHandedness() const;
/// Returns true if the vectors in the matrix form a right-handed
/// coordinate system.
bool IsRightHanded() const {
return GetHandedness() == 1.0;
}
/// Returns true if the vectors in matrix form a left-handed
/// coordinate system.
bool IsLeftHanded() const {
return GetHandedness() == -1.0;
}
we find code like this throughout OpenUSD:
// negate the angles
*thetaSw *= -handedness;
*thetaFB *= -handedness;
*thetaTw *= -handedness;
usd files have it as a token
uniform token orientation = "leftHanded" (
hidden = true
)
I agree that instead of a handedness float, we should match the orientation token usage.
12 tasks
Contributor
|
Link to Rendered Proposal for convenience |
1 task
exposure and sensitivity have already landed in OpenUSD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Physical Cameras for USD
On behalf of the Cameras in USD Working Group:
This schema usefully bridges the description of physical cameras to USD scenes.
rendered link:
https://github.com/usd-wg/OpenUSD-proposals/blob/physical-camera/proposals/physical-cameras/README.md
The physical camera is a primitive meant to be a target for construction of
a physical camera model through applied, and multiply applied schemas.
Supporting Materials
n/a
Contributing