NVIDIA: Add prim flag HasAbstractSpecifier to filter prim with class specifier#3829
Open
roggiezhang-nv wants to merge 3 commits intoPixarAnimationStudios:devfrom
Open
NVIDIA: Add prim flag HasAbstractSpecifier to filter prim with class specifier#3829roggiezhang-nv wants to merge 3 commits intoPixarAnimationStudios:devfrom
roggiezhang-nv wants to merge 3 commits intoPixarAnimationStudios:devfrom
Conversation
5 tasks
Contributor
Author
|
@nvmkuruc for vis. |
Collaborator
|
Filed as internal issue #USD-11482 (This is an automated message. See here for more information.) |
nvmkuruc
reviewed
Oct 14, 2025
pxr/usd/usdGeom/pointInstancer.h
Outdated
| /// or UsdPrimRange traversals. Usd prims each have a | ||
| /// \ref Usd_PrimSpecifiers "specifier" of "def", "over", or "class". The | ||
| /// default traversals skip over prims that are "pure overs" or classes. So | ||
| /// default traversals skip over prims that are "pure overs". So |
Collaborator
There was a problem hiding this comment.
I think it was correct to leave or classes here.
826caef to
a67d4f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
There's no way to identify a concretely define subgraph using traversal predicates because "IsAbstract" will match all ancestors.
This PR adds a
HasAbstractSpecifiersimilar toHasDefiningSpecifieras a prim flag.Example
/abstract_root/conrete_subgraphis defined but abstract because of its abstract ancestor. AHasAbstractSpecifierprim flag would allow the specification to enabling traversal of the decendants ofconcrete_subgraphusing the predicateHasDefiningSpecifier && !HasAbstractSpecifier.See discussion in https://forum.aousd.org/t/pointinstancer-prototype-scope-best-practices/2662.
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)