Autodesk: [hdx] Improve pickTask to use deep selection only when enabled #3911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add logic to change the technique used when creating the glslfx shader to include or exclude deep selection code. Before the change, the `RenderDeepPicks` was always executed since the PickBuffer binding was always included in the shader through the glslfx layout. - Add logic to clean up the pick buffer when deep selection is disabled. - Add the `technique` attribute to the hash computation of a HioGlslfx object. - Change the pxr/imaging/hdx/shaders/renderPassPickingShader.glslfx file to define a `withDeepSelect` and a `noDeepSelect` technique,
Collaborator
|
Filed as internal issue #USD-11699 (This is an automated message. See here for more information.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
RenderDeepPickswas always executed since the PickBuffer binding was always included in the shader through the glslfx layout.techniqueattribute to the hash computation of a HioGlslfx object.withDeepSelectand anoDeepSelecttechnique,Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)