convert bare assert statements in TestCase methods to self.assertEqual#3965
Open
pmolodo wants to merge 1 commit intoPixarAnimationStudios:devfrom
Open
Conversation
...where appropriate, and the comparison is simple. This makes errors report more useful information - particularly helpful for infrequent or hard-to-reproduce failures. These changes were automatically generated using a libCST script to parse source code and make changes in a syntax-safe way. This is the exact script used to make these changes: https://github.com/pmolodo/convert_assert_statements/blob/f2a096191eef3d61fd7e808feeab6b5111a57042/convert_TestCase_assert_statements_to_assert_methods.py
86d5c58 to
853ddbc
Compare
Collaborator
|
Filed as internal issue #USD-11845 (This is an automated message. See here for more information.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE for reviewing:
Since these changes were automatically generated, I recommend reviewing the libCST script used to generate them, linked below, and a sampling of the changes.
Description of Change(s)
...where appropriate, and the comparison is simple.
This makes errors report more useful information - particularly helpful for infrequent or hard-to-reproduce failures.
These changes were automatically generated using a libCST script to parse source code and make changes in a syntax-safe way. This is the exact script used to make these changes:
https://github.com/pmolodo/convert_assert_statements/blob/f2a096191eef3d61fd7e808feeab6b5111a57042/convert_TestCase_assert_statements_to_assert_methods.py
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes*
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)
*Technically, all unit tests did not pass - but the same set failed that also failed on an unmodified pixar/dev branch. These were the failures (all Usdview / UsdImagingGL):