Makes the 'ids' for a UsdGeomPointInstancer available to shaders#3977
Open
crydalch wants to merge 1 commit intoPixarAnimationStudios:devfrom
Open
Makes the 'ids' for a UsdGeomPointInstancer available to shaders#3977crydalch wants to merge 1 commit intoPixarAnimationStudios:devfrom
crydalch wants to merge 1 commit intoPixarAnimationStudios:devfrom
Conversation
Collaborator
|
Filed as internal issue #USD-11872 (This is an automated message. See here for more information.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Makes the 'ids' for a UsdGeomPointInstancer available to shaders, without requiring users author a separate Primvar for this purpose. The mesh has matching values for ids, authored as a Primvar, just to visually ensure we're getting the same results.
It doesn't preclude authoring a different
primvars:ids, as explicitly authoredprimvars:idstake precedence. We also did some testing with an internal build of Karma, and are seeing the same, expected behavior.Here are the scene files we used for testing:
PointInstancer_IDs_test_scenes.zip
Fixes Issue(s)
#3976
Storm
In order to validate this with Storm, we had to make some changes, which are in this patch. However we aren't sure if the Storm/UsdMaterialX changes are the best way forward. We leave the patch here, for any interested parties to pick up as a starting point for having Storm to support integer primvars, as we probably aren't best situation to shepherd this into the baseline :)
ids_Storm_MtlX_support.patch