Optimize getting the palette index for palette compression using SIMD.#2405
Open
IntegratedQuantum wants to merge 1 commit intoPixelGuys:masterfrom
Open
Optimize getting the palette index for palette compression using SIMD.#2405IntegratedQuantum wants to merge 1 commit intoPixelGuys:masterfrom
IntegratedQuantum wants to merge 1 commit intoPixelGuys:masterfrom
Conversation
Collaborator
|
How did you measure performance impact? |
Member
Author
|
I looked at it with a sampling profiler, not terribly precise I know. Maybe I'll make a better worst-case benchmark for this in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler is poor at optimizing search loops like this, since it doesn't have enough information (it must not access the memory beyond the last entry and thus is stuck iterating element by element).
So I decided to try and throw some SIMD on this, and the easiest way to use SIMD is possible is to align the vector and blindly access memory beyond the length limit, and it actually is not a lot more complex than the non-SIMD code (see godbolt).
I also did some measurements, but getting the palette is not a common operation, and thus overall performance impact is below 1%, the given function measured alone though is about 17-50% faster depending on the use case.
But to be honest this is mostly about fixing the worst-case performance (which of course I did not care to measure :P)
fixes #318