Change block interaction override to crouch keybind instead of shift#2531
Open
hazelmeowing wants to merge 1 commit intoPixelGuys:masterfrom
Open
Change block interaction override to crouch keybind instead of shift#2531hazelmeowing wants to merge 1 commit intoPixelGuys:masterfrom
hazelmeowing wants to merge 1 commit intoPixelGuys:masterfrom
Conversation
Member
|
We used to have a key for this (which got removed in the refactoring of #2144) I do agree that we should have this remappable, but I do not think that this is the right approach. Tying it to crouching, a completely unrelated activity. Also I do like the modifiers in the sense that now there is a clear and fixed list of key modifiers you can check, instead of having to query a random key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Block interaction override" being the key you hold to place a block while looking at something that would normally do something else, currently it is always
mods.shiftwhich can be problematic. For example I use shift for sprint and toggle sprint, meaning whenever I want to use this I toggle whether I am running, which is bothersome (additionally, some people might not havemods.shiftbound for anything else, which would make this very unnatural). I don't think it is necessary to add a special keybind for this, and changing it to"crouch"will be familiar for people coming from Minecraft.I did notice however there is
dropFromHandwhich also checksmods.shiftto decide whether to drop a whole stack or not, currently I have not changed this as I checked in Minecraft and for some reason this is always shift unlike block interaction overriding, I do feel this is an inconsistency and I obviously don't think Cubyz should seek to be inconsistent just because Minecraft is, but I am unsure whether it would be better to add a new keybind for this or make it"crouch"