Removed some small references still related to the old version of BehaviorTree#46
Open
SamueleSandrini wants to merge 2 commits intoPlanSys2:rollingfrom
Open
Removed some small references still related to the old version of BehaviorTree#46SamueleSandrini wants to merge 2 commits intoPlanSys2:rollingfrom
SamueleSandrini wants to merge 2 commits intoPlanSys2:rollingfrom
Conversation
fmrico
requested changes
Mar 7, 2024
Contributor
fmrico
left a comment
fmrico
left a comment
There was a problem hiding this comment.
And you will need to add a new workflow in .github , and a new status badge for this workflow in Readme
| @@ -0,0 +1,156 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Please, remove this file in this PR
| @@ -0,0 +1,121 @@ | |||
| { | |||
| cmake_minimum_required(VERSION 3.5) | ||
| project(plansys2_auction_example) | ||
|
|
||
| set(CMAKE_BUILD_TYPE Debug) |
| # Declare the launch options | ||
| ld.add_action(plansys2_cmd) | ||
| ld.add_action(nav2_cmd) | ||
| # ld.add_action(nav2_cmd) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed references still related to the old version of Behavior Tree V3.8 (
BT::NodeConfigurationnowBT::NodeConfigin BT 4.x naming convention).Note: In the launch file
plansys2_bt_example_launch.pyof theplansys2_bt_examplepackage, there are still theserver_portandpublisher_portparameters passed to the action nodes (here), which were actually removed from the last PR as communication with Groot was removed. I have left them in case in the future we decide to enable communication with Groot2 or a light Groot-Groot2 interface.