Feat: performance-enhancements#156
Open
garciacsci wants to merge 4 commits intoPlatonymous:masterfrom
Open
Conversation
garciacsci
changed the title
Author
|
Compiled version can be found here |
|
what is |
Author
|
It was a leftover from when I refactored, I think I left it in as a reference but don't remember now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was suffering performance issues on larger resolutions and saw that a lot of repeat calculations were being run inside of the draw function. This branch moves a lot of that math outside of the draw loop by caching anything that only needs to be calculated once (as far as I could tell). I also did a little refactoring to reduce some repeat code I saw as well.
After making these changes and rebuilding the mod I no longer had any perceptible performance hits and 1oxnes and talkohlooey's seasonal portraits for SVE worked as expected.