Reboot #471
Merged
Reboot #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koalk
reviewed
Jan 16, 2025
| @@ -41,7 +44,7 @@ class ReactNativeMcuManagerModule : Module() { | |||
| try { | |||
| val device: BluetoothDevice = bluetoothAdapter.getRemoteDevice(macAddress) | |||
There was a problem hiding this comment.
The way we get the bluetooth adapter there seems to be deprecated in the latest versions of the ble library. If we are bumping the ble library we should also get that fixed
private val bluetoothManager = context.getSystemService(Context.BLUETOOTH_SERVICE) as BluetoothManager
private val bluetoothAdapter = bluetoothbluetoothManager.getAdapter()
Koalk
approved these changes
Jan 17, 2025
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to request device reset.
Also updates the example app, stealing some bits from #470 (since it's blocked) to use Expo Router. Key change is device selection now happens in a separate screen, so scanning stops once a device is selected
Self Review:
Smoke Tests: