Feature encapsulate #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r encapsulation feature (are these really needed?)
…and conenctions were not created
…multiple destiny connections was replaced by multiple routers instead of a single router
…visible in the inspector
…are the actual preset name
…dio/ofxOceanode into feature-encapsulate
… for encapsulate compatibility
…dio/ofxOceanode into feature-encapsulate
Removed getParameterTypeName -> used ofParameter::valueType()
Removed mapParameterTypeToRouterName -> added method to typesRegistry for getting the defined type name ("v_f" for vector<float>) from the automatic type name that valueType() gives.
Added the custom name to all types.
Also create routers and portals for this vector<T> type
…ttons invisible in the inspector" This reverts commit 96124ed.
This reverts commit 5e2ada5.
This reverts commit a8437d2.
…ed to share the actual preset name" This reverts commit b34be47. # Conflicts: # src/Controls/ofxOceanodePresetsController.cpp
…set name" This reverts commit 6b48fa2. # Conflicts: # src/ofxOceanodeShared.h
… inspector" This reverts commit 678b553.
This reverts commit fce8338.
This reverts commit 24c8370.
This reverts commit 8fc3a5c.
This reverts commit d48587b.
This reverts commit f578e56.
This reverts commit 04e1670.
This reverts commit a93764a. # Conflicts: # src/ofxOceanodeShared.h
This reverts commit 1b09bc5. # Conflicts: # src/Controls/ofxOceanodePresetsController.cpp
…eeded for encapsulation feature (are these really needed?)" This reverts commit f3d1321.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.