feat(embedded-mongodb): add support to launch mongo as a replicaset #2698
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,10 @@ public class MongodbProperties extends CommonContainerProperties { | |
| private String username; | ||
| private String password; | ||
| private String database = "test"; | ||
| /** | ||
| * If provided, mongodb will be started as a replica set with the given name. Default: null (standalone mode). | ||
| */ | ||
| private String replicaSetName; | ||
|
|
||
| public MongodbProperties() { | ||
| this.setCapabilities(List.of(Capability.ALL)); | ||
|
|
@@ -36,6 +39,6 @@ public String getDefaultDockerImage() { | |
| // Please don`t remove this comment. | ||
| // renovate: datasource=docker | ||
| // https://hub.docker.com/_/mongo | ||
| return "mongodb/mongodb-community-server:8.2.2-ubuntu2204"; | ||
|
Collaborator
There was a problem hiding this comment. update also version in other places metron2@4d635ab
Collaborator
There was a problem hiding this comment. do not forget add it to readme |
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package com.playtika.testcontainer.mongodb; | ||
|
|
||
| import lombok.AllArgsConstructor; | ||
| import lombok.SneakyThrows; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.testcontainers.containers.wait.strategy.AbstractWaitStrategy; | ||
| import org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy; | ||
|
|
||
| @Slf4j | ||
| @AllArgsConstructor | ||
| public class MongodbWaitStrategy extends AbstractWaitStrategy { | ||
|
|
||
| private final MongodbProperties properties; | ||
|
|
||
| @Override | ||
| @SneakyThrows | ||
| protected void waitUntilReady() { | ||
| log.info("Waiting for mongodb to start"); | ||
| new LogMessageWaitStrategy().withRegEx(".*Waiting for connections.*").waitUntilReady(waitStrategyTarget); | ||
| if (properties.getReplicaSetName() != null) { | ||
ijusti marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // The docker container will restart mongod and initialize the replicaset, so we just have to wait for that to finish now. | ||
| log.info("Waiting for mongodb to become primary."); | ||
|
|
||
| LogMessageWaitStrategy logMessageWaitStrategy = new LogMessageWaitStrategy().withRegEx(".*database writes are now permitted.*"); | ||
| logMessageWaitStrategy.waitUntilReady(waitStrategyTarget); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # Mongo requires a keyfile for replicasets, but the docker image does not generate one. | ||
| # The image does let you run this arbitrary script after db initialization. | ||
|
|
||
| echo "testcontainers" > /data/configdb/mongod.keyfile | ||
| chmod 400 /data/configdb/mongod.keyfile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
|
|
||
| storage: | ||
| dbPath: /data/db | ||
|
|
||
| processManagement: | ||
| timeZoneInfo: /usr/share/zoneinfo | ||
|
|
||
| net: | ||
| port: 27017 | ||
| bindIp: 0.0.0.0 | ||
|
|
||
| security: | ||
| keyFile: /data/configdb/mongod.keyfile | ||
| authorization: enabled | ||
|
|
||
| replication: | ||
| replSetName: ${replica-set-name} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| package com.playtika.testcontainer.mongodb; | ||
|
|
||
|
|
||
| import lombok.Value; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.boot.autoconfigure.EnableAutoConfiguration; | ||
| import org.springframework.boot.test.context.SpringBootTest; | ||
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.core.env.ConfigurableEnvironment; | ||
| import org.springframework.data.annotation.Id; | ||
| import org.springframework.data.mongodb.core.MongoTemplate; | ||
|
|
||
| import java.time.Instant; | ||
| import java.util.UUID; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| @Slf4j | ||
| @SpringBootTest( | ||
| properties = { | ||
| "embedded.mongodb.username=root", | ||
| "embedded.mongodb.password=letmein", | ||
| "embedded.mongodb.replica-set-name=rs0", | ||
| "spring.data.mongodb.uri=mongodb://${embedded.mongodb.username}:${embedded.mongodb.password}@${embedded.mongodb.host}:${embedded.mongodb.port}/${embedded.mongodb.database}?replicaSet=${embedded.mongodb.replica-set-name}&directConnection=true&authSource=admin" | ||
| } | ||
| , classes = EmbeddedMongodbBootstrapReplicaSetConfigurationTest.TestConfiguration.class | ||
| ) | ||
| public class EmbeddedMongodbBootstrapReplicaSetConfigurationTest { | ||
|
|
||
| @Autowired | ||
| MongoTemplate mongoTemplate; | ||
|
|
||
| @Autowired | ||
| ConfigurableEnvironment environment; | ||
|
|
||
|
|
||
| @Test | ||
| public void shouldSaveAndGet() { | ||
| String someId = UUID.randomUUID().toString(); | ||
| Foo foo = new Foo(someId, "foo", Instant.parse("2019-09-26T07:57:12.801Z"), -42L); | ||
| mongoTemplate.save(foo); | ||
|
|
||
| assertThat(mongoTemplate.findById(someId, Foo.class)).isEqualTo(foo); | ||
| } | ||
|
|
||
| @Test | ||
| public void propertiesAreAvailable() { | ||
| assertThat(environment.getProperty("embedded.mongodb.port")).isNotEmpty(); | ||
| assertThat(environment.getProperty("embedded.mongodb.host")).isNotEmpty(); | ||
| assertThat(environment.getProperty("embedded.mongodb.username")).isNotEmpty(); | ||
| assertThat(environment.getProperty("embedded.mongodb.password")).isNotEmpty(); | ||
| assertThat(environment.getProperty("embedded.mongodb.database")).isNotEmpty(); | ||
| assertThat(environment.getProperty("embedded.mongodb.replica-set-name")).isNotEmpty(); | ||
|
Comment on lines
+50
to
+55
Collaborator
There was a problem hiding this comment. do not use environment. add fields with spring Value annotation
Contributor
Author
There was a problem hiding this comment. I was following the convention of the other test, do you want me to change both of them? I pretty much copied that one and added this line for the replicaset mode. |
||
| } | ||
|
|
||
| @Value | ||
| static class Foo { | ||
| @Id | ||
| String someId; | ||
| String someString; | ||
| Instant someTimestamp; | ||
| Long someNumber; | ||
| } | ||
|
|
||
| @EnableAutoConfiguration | ||
| @Configuration | ||
| static class TestConfiguration { | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.