Replace UrlEncode library with local implementation. #811
+68
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…ncode include/effects/matrix/PatternSubscribers.h: Removed unused include of UrlEncode platformio: Remove external dependency of UrlEncode src/deviceconfig.cpp: If we don't have WiFi, we don't have a URL. src/network.cpp: Add textbook implementaion of urlEncode. effects/matrix/PatternSubscribers.h: Removed unused include of UrlEncode
rbergen
reviewed
Jan 5, 2026
Comment on lines
108
to
116
| DeviceConfig::ValidateResponse DeviceConfig::ValidateOpenWeatherAPIKey(const String &newOpenWeatherAPIKey) | ||
| { | ||
| #if ENABLE_WIFI | ||
| HTTPClient http; | ||
|
|
||
| String url = "http://api.openweathermap.org/data/2.5/weather?lat=0&lon=0&appid=" + urlEncode(newOpenWeatherAPIKey); | ||
|
|
||
| http.begin(url); | ||
|
|
Collaborator
There was a problem hiding this comment.
I think we should "if #ENABLE_WIFI" the whole ValidateOpenWeatherAPIKey() function, obviously including its declaration in deviceconfig.h. Anything calling it should also not be enabled when WIFI isn't.
(This may sound like nitpicking, but I just hate a function conditionally not doing what it clearly claims to do.)
|
|
||
| #include <Arduino.h> | ||
|
|
||
| String urlEncode(const String& str); |
Collaborator
There was a problem hiding this comment.
I suggest we add a comment to indicate where the definition lives, that not being UrlEncode.cpp.
Which is something I was actually going to challenge, but I can see the logic after thinking it through from a few different angles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed
UrlEncodethird-party dependency.include/UrlEncode.hproto and new (better) body insrc/network.cpp.Uses RFC 1738 style percent-encoding.
urlEncodefunction and its usage insrc/deviceconfig.cppwith#if ENABLE_WIFI. It may be possible to do better later, but we agree for now that without WIFI, there is no URL.UrlEncode.hfromPatternStocks.handPatternSubscribers.h.Contributing requirements
mainas the target branch.