Closed
Conversation
- Added new stop words: as, if, off, out, so - Added support for Apple product names (iPhone, iPad, etc.) - Updated tests to cover new capitalization rules
jwalterss
force-pushed
the
HNT-682-add-new-capitalization-rules
branch
from
f58db84 to
0dcce14
Compare
…est coverage - Refactored implementation for better readability with clear separation of concerns - Converted stop words to Set for O(1) lookups - Added comprehensive documentation and comments - Improved handling of special cases (quotes, colons, Apple products) - Removed lowercaseAfterApostrophe export as it's now internal - Updated tests to match new implementation
jwalterss
force-pushed
the
HNT-682-add-new-capitalization-rules
branch
from
0dcce14 to
c592e11
Compare
mmiermans
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todos
Deployment
No special deployment requirements. This is a frontend-only change to the AP
title case utility function.
Reference
Documentation here:
Tickets:
Linked PR
Implementation Decisions
Stop Words: Added 'as', 'if', 'off', 'out', 'so', and 'vs' to the stop
words list to align with AP style guidelines. These words should remain
lowercase unless they start a title or follow a colon.
Apple Product Names: Added special handling for Apple product names
(iPhone, iPad, iPod, iMac, iCloud, iTunes, iBooks, iMessage) to ensure the
'i' remains lowercase when these words appear at the beginning of a title or
after capitalization triggers.
Test Coverage: Added comprehensive test cases for both the new stop
words and Apple product name handling to ensure the implementation works
correctly in various contexts.