Skip to content

#626 Fixed issue where custom completion rules cannot be saved #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: MOODLE_404_STABLE
Choose a base branch
from
Open

#626 Fixed issue where custom completion rules cannot be saved #630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions mod_form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,12 @@ public function validation($data, $files) {
}

/**
* Add any completion rules for the form.
* @return string[]
* Returns the suffixed name for custom completion elements.
*
* @param string $fieldname
* @return string
*/
public function add_completion_rules() {
protected function get_suffixed_name(string $fieldname): string {
global $CFG;

// Changes for Moodle 4.3 - MDL-78516.
Expand All @@ -207,11 +209,18 @@ public function add_completion_rules() {
} else {
$suffix = $this->get_suffix();
}
return $fieldname . $suffix;
}

/**
* Add any completion rules for the form.
* @return string[]
*/
public function add_completion_rules() {
$mform =& $this->_form;
$mform->addElement('checkbox', 'completionsubmit' . $suffix, '',
$mform->addElement('checkbox', $this->get_suffixed_name('completionsubmit'), '',
get_string('completionsubmit', 'questionnaire'));
return ['completionsubmit' . $suffix];
return [$this->get_suffixed_name('completionsubmit')];
}

/**
Expand All @@ -220,7 +229,7 @@ public function add_completion_rules() {
* @return bool
*/
public function completion_rule_enabled($data) {
return !empty($data['completionsubmit']);
return !empty($data[$this->get_suffixed_name('completionsubmit')]);
}

}