Skip to content

Conversation

Bartman119
Copy link

Fix negative position setting for edited questionnaire and remove position updating for other questionnaires

@Bartman119
Copy link
Author

Fix regarding #619

@mchurchward
Copy link
Contributor

Thanks for this. Can you also provide a Behat test that shows the error before the fix, and no error after the fix?

@Bartman119
Copy link
Author

Sure, I will provide appropriate behat tests at the earliest convenience

Thanks for this. Can you also provide a Behat test that shows the error before the fix, and no error after the fix?

@HirotoKagotani
Copy link

How about using a placeholder just in case?

if ($records = $DB->get_records_select('questionnaire_question', 'surveyid = :sid', ['sid' => $sid], 'position ASC')) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants