Skip to content

Questionnaire: Make summary page even more intuitive #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: MOODLE_404_STABLE
Choose a base branch
from
Open

Questionnaire: Make summary page even more intuitive #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lang/en/questionnaire.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,7 @@
$string['responseformat'] = 'Response format';
$string['responseoptions'] = 'Response options';
$string['responses'] = 'Responses';
$string['responses_breakdown'] = '(Submissions: {$a->responses} | In progress: {$a->incomplete})';
$string['responseview'] = 'Students can view ALL responses';
$string['responseview_help'] = 'You can specify who can see the responses of all respondents to submitted questionnaires (general statistics tables).';
$string['responseview_link'] = 'mod/questionnaire/mod#Response_viewing';
Expand Down
17 changes: 17 additions & 0 deletions questionnaire.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2887,6 +2887,23 @@ public function survey_results($rid = '', $uid=false, $pdf = false, $currentgrou
if ($userview === 'y') {
$respondentstring = get_string('submissions', 'questionnaire');
}
if (!$userview) {
$completedcount = 0;
$inprogresscount = 0;

foreach ($rows as $row) {
if ($row->complete === 'y') {
$completedcount++;
} else if ($row->complete === 'n') {
$inprogresscount++;
}
}
$numresps .= ' ' . get_string('responses_breakdown', 'questionnaire',
[
'responses' => $completedcount,
'incomplete' => $inprogresscount,
]);
}
$this->page->add_to_page('respondentinfo',
' ' . $respondentstring . ': <strong>' . $numresps . '</strong>');
if (empty($rows)) {
Expand Down
4 changes: 2 additions & 2 deletions tests/behat/check_responses.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Feature: Review responses
Then I should see "View all responses"
And I navigate to "View all responses" in current page administration
And I should see "View Default order"
And I should see "Responses: 7"
And I should see "Responses: 7 (Submissions: 6 | In progress: 1)"
And I set the field "View" to "Full submissions"
And I should see "Submissions: 6"
And I set the field "View" to "Responses not submitted"
Expand Down Expand Up @@ -70,7 +70,7 @@ Feature: Review responses
Then I should see "1 / 6"
And I follow "Summary"
And I should see "View Default order"
And I should see "Responses: 6"
And I should see "Responses: 6 (Submissions: 6 | In progress: 0)"
And I follow "Delete ALL Responses"
Then I should see "Are you sure you want to delete ALL the responses in this questionnaire?"
And I press "Delete"
Expand Down
2 changes: 1 addition & 1 deletion tests/behat/check_responses_capabilities.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Feature: Review responses with different capabilities
And I navigate to "View all responses" in current page administration
Then I should see "All responses"
And I should see "View Default order"
And I should see "Responses: 7"
And I should see "Responses: 7 (Submissions: 6 | In progress: 1)"
And I log out

@javascript
Expand Down