Moodle Plugin CI for 500#642
Closed
lucaboesch wants to merge 2 commits intoPoetOS:MOODLE_500_STABLEfrom
Closed
Conversation
mchurchward
force-pushed
the
MOODLE_500_STABLE
branch
from
c337899 to
fa88988
Compare
lucaboesch
force-pushed
the
moodlepluginci_500
branch
from
4e8402f to
3eb09f7
Compare
mchurchward
requested changes
Nov 1, 2025
Contributor
mchurchward
left a comment
mchurchward
left a comment
There was a problem hiding this comment.
Not sure if this is correct now. The commit changes a unit test, and it fails the CI.
lucaboesch
force-pushed
the
moodlepluginci_500
branch
from
3eb09f7 to
6ef66a7
Compare
lucaboesch
force-pushed
the
moodlepluginci_500
branch
from
6ef66a7 to
3aa3b99
Compare
Contributor
Author
|
Sorry @mchurchward. |
Contributor
|
Thanks. Can you describe what this fix is for? |
Contributor
Author
|
Yes, sure. Best, |
Contributor
|
Thanks Luca. But what I meant was something in the description of the pull request that clearly defines what it is for. And more specific than "won't pass unit tests". Also, before this is applied, unit tests are passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.