Skip to content

if block with data is not used#662

Open
sharpchi wants to merge 1 commit intoPoetOS:MOODLE_500_STABLEfrom
sharpchi:GHI624_404_data_does_nothing
Open

if block with data is not used#662
sharpchi wants to merge 1 commit intoPoetOS:MOODLE_500_STABLEfrom
sharpchi:GHI624_404_data_does_nothing

Conversation

@sharpchi
Copy link
Contributor

Had a good look, and it appears this code doesn't do anything - doesn't throw any errors either.

@mchurchward mchurchward changed the base branch from MOODLE_404_STABLE to MOODLE_500_STABLE November 12, 2025 15:50
@mchurchward
Copy link
Contributor

I have changed the base to the latest default branch. Errors will need to be fixed.
BUT - are you sure this is needed? Are you sure this case cannot happen? Seems like an unnecessary and risky change.

@lucaboesch
Copy link
Contributor

lucaboesch commented Nov 12, 2025

Are you sure, @sharpchi that the solution isn't to simply change this to $response, which if I understand correctly is what #624 alludes to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants