Skip to content

Allow for union types in call signature return if separate concerete property#152

Merged
timkpaine merged 1 commit intomainfrom
tkp/un
Nov 5, 2025
Merged

Allow for union types in call signature return if separate concerete property#152
timkpaine merged 1 commit intomainfrom
tkp/un

Conversation

@timkpaine
Copy link
Member

No description provided.

@timkpaine timkpaine added type: bug Concrete, reproducible bugs type: enhancement Minor improvements labels Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Test Results

472 tests  +3   468 ✅ +3   41s ⏱️ -1s
  1 suites ±0     4 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit cb9d44a. ± Comparison against base commit ca4b202.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 85.88235% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.09%. Comparing base (ca4b202) to head (cb9d44a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ccflow/callable.py 76.19% 4 Missing and 6 partials ⚠️
ccflow/tests/test_callable.py 95.34% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   95.18%   95.09%   -0.09%     
==========================================
  Files         130      130              
  Lines        7542     7609      +67     
  Branches      491      501      +10     
==========================================
+ Hits         7179     7236      +57     
- Misses        242      248       +6     
- Partials      121      125       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…property

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Copy link
Collaborator

@ptomecek ptomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge the duplicative logic in a single place down the road.

@timkpaine timkpaine merged commit fcb1716 into main Nov 5, 2025
4 of 6 checks passed
@timkpaine timkpaine deleted the tkp/un branch November 5, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Concrete, reproducible bugs type: enhancement Minor improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments