Skip to content

Commit 38cbd62

Browse files
committed
Make apps Qt6 compatible
1 parent 383b530 commit 38cbd62

File tree

13 files changed

+24
-17
lines changed

13 files changed

+24
-17
lines changed

apps/cloud_composer/src/cloud_composer.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <pcl/apps/cloud_composer/signal_multiplexer.h>
1111
#include <pcl/apps/cloud_composer/point_selectors/interactor_style_switch.h>
1212

13+
#include <QActionGroup>
1314
#include <QMessageBox>
1415
#include <QPluginLoader>
1516
#include <QUndoGroup>

apps/in_hand_scanner/CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,11 @@ PCL_ADD_EXECUTABLE(
9191
${IMPL_INCS}
9292
${UI}
9393
BUNDLE)
94+
9495
target_link_libraries("${EXE_NAME}" ${SUBSUBSYS_LIBS} ${OPENGL_LIBRARIES} ${QTX}::Concurrent ${QTX}::Widgets ${QTX}::OpenGL)
96+
if (${QTX} MATCHES "Qt6")
97+
target_link_libraries("${EXE_NAME}" ${QTX}::OpenGLWidgets)
98+
endif()
9599

96100
pcl_add_includes("${SUBSUBSYS_NAME}" "${SUBSUBSYS_NAME}" ${INCS})
97101
pcl_add_includes("${SUBSUBSYS_NAME}" "${SUBSUBSYS_NAME}/impl" ${IMPL_INCS})
@@ -108,6 +112,9 @@ PCL_ADD_EXECUTABLE(
108112
BUNDLE)
109113

110114
target_link_libraries(pcl_offline_integration ${SUBSUBSYS_LIBS} ${OPENGL_LIBRARIES} ${QTX}::Concurrent ${QTX}::Widgets ${QTX}::OpenGL)
115+
if (${QTX} MATCHES "Qt6")
116+
target_link_libraries(pcl_offline_integration ${QTX}::OpenGLWidgets)
117+
endif()
111118

112119
# Add to the compound apps target
113120
list(APPEND PCL_APPS_ALL_TARGETS ${PCL_IN_HAND_SCANNER_ALL_TARGETS})

apps/in_hand_scanner/include/pcl/apps/in_hand_scanner/opengl_viewer.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
#include <pcl/pcl_exports.h>
4747
#include <pcl/pcl_macros.h>
4848

49-
#include <QGLWidget>
49+
#include <QOpenGLWidget>
5050

5151
#include <iomanip>
5252
#include <mutex>
@@ -102,7 +102,7 @@ class FaceVertexMesh {
102102
* \note Currently you have to derive from this class to use it. Implement the
103103
* paintEvent: Call the paint event of this class and declare a QPainter.
104104
*/
105-
class PCL_EXPORTS OpenGLViewer : public QGLWidget {
105+
class PCL_EXPORTS OpenGLViewer : public QOpenGLWidget {
106106
Q_OBJECT
107107

108108
public:

apps/in_hand_scanner/src/offline_integration.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
#include <QApplication>
5151
#include <QFileDialog>
5252
#include <QKeyEvent>
53+
#include <QPainter>
5354
#include <QtConcurrent>
5455
#include <QtCore>
5556

apps/in_hand_scanner/src/opengl_viewer.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
#include <pcl/common/centroid.h>
5757
#include <pcl/common/impl/centroid.hpp> // TODO: PointIHS is not registered
5858

59+
#include <QApplication>
5960
#include <QtOpenGL>
6061

6162
////////////////////////////////////////////////////////////////////////////////
@@ -101,7 +102,7 @@ pcl::ihs::detail::FaceVertexMesh::FaceVertexMesh(const Mesh& mesh,
101102
////////////////////////////////////////////////////////////////////////////////
102103

103104
pcl::ihs::OpenGLViewer::OpenGLViewer(QWidget* parent)
104-
: QGLWidget(parent)
105+
: QOpenGLWidget(parent)
105106
, timer_vis_(new QTimer(this))
106107
, colormap_(Colormap::Constant(255))
107108
, vis_conf_norm_(1)
@@ -1195,8 +1196,8 @@ pcl::ihs::OpenGLViewer::wheelEvent(QWheelEvent* event)
11951196
std::max((cam_pivot_ - R_cam_ * o - t_cam_).norm(), .1 / scaling_factor_) / d;
11961197

11971198
// http://doc.qt.digia.com/qt/qwheelevent.html#delta
1198-
t_cam_ +=
1199-
scale * Eigen::Vector3d(R_cam_ * (ez * static_cast<double>(event->delta())));
1199+
t_cam_ += scale * Eigen::Vector3d(
1200+
R_cam_ * (ez * static_cast<double>(event->angleDelta().y())));
12001201
}
12011202
}
12021203

apps/modeler/src/main_window.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ pcl::modeler::MainWindow::updateRecentActions(
282282
}
283283

284284
recent_items.removeDuplicates();
285-
int recent_number = std::min(int(MAX_RECENT_NUMBER), recent_items.size());
285+
int recent_number = std::min<int>(int(MAX_RECENT_NUMBER), recent_items.size());
286286
for (int i = 0; i < recent_number; ++i) {
287287
QString text = tr("%1 %2").arg(i + 1).arg(recent_items[i]);
288288
recent_actions[i]->setText(text);

apps/point_cloud_editor/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ PCL_ADD_EXECUTABLE(
8787
${INCS})
8888

8989
target_link_libraries("${EXE_NAME}" ${QTX}::Widgets ${QTX}::OpenGL ${OPENGL_LIBRARIES} ${BOOST_LIBRARIES} pcl_common pcl_io pcl_filters)
90+
if (${QTX} MATCHES "Qt6")
91+
target_link_libraries("${EXE_NAME}" ${QTX}::OpenGLWidgets)
92+
endif()
9093

9194
PCL_ADD_INCLUDES("${SUBSUBSYS_NAME}" "${SUBSYS_NAME}/${SUBSUBSYS_NAME}" ${INCS})
9295
PCL_MAKE_PKGCONFIG(${EXE_NAME} COMPONENT ${SUBSUBSYS_NAME} DESC ${SUBSUBSYS_DESC})

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/cloudEditorWidget.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,15 @@
4949

5050
#include <pcl/memory.h> // for pcl::shared_ptr
5151

52-
#include <QGLWidget>
52+
#include <QOpenGLWidget>
5353

5454
#include <functional>
5555

5656
class Selection;
5757

5858
/// @brief class declaration for the widget for editing and viewing
5959
/// point clouds.
60-
class CloudEditorWidget : public QGLWidget
60+
class CloudEditorWidget : public QOpenGLWidget
6161
{
6262
Q_OBJECT
6363
public:

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/select2DTool.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040

4141
#pragma once
4242

43-
#include <qgl.h>
43+
#include <qopengl.h>
4444
#include <pcl/apps/point_cloud_editor/toolInterface.h>
4545
#include <pcl/apps/point_cloud_editor/localTypes.h>
4646

apps/point_cloud_editor/src/cloud.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
/// @author Yue Li and Matthew Hielsberg
3939

4040
#include <algorithm>
41-
#include <qgl.h>
4241
#include <pcl/apps/point_cloud_editor/cloud.h>
4342
#include <pcl/apps/point_cloud_editor/selection.h>
4443
#include <pcl/apps/point_cloud_editor/localTypes.h>

0 commit comments

Comments
 (0)