Check dynamic_cast output before dereferencing in modeler

Author: gnawme

apps/modeler/src/cloud_mesh.cpp

@@ -156,6 +156,8 @@ pcl::modeler::CloudMesh::updateVtkPoints()
     vtk_points_->SetData(vtkSmartPointer<vtkFloatArray>::New());
 
   auto* data = dynamic_cast<vtkFloatArray*>(vtk_points_->GetData());
+  if (!data)
+    return;
   data->SetNumberOfComponents(3);
 
   // If the dataset has no invalid values, just copy all of them

apps/modeler/src/normals_actor_item.cpp

@@ -69,6 +69,8 @@ pcl::modeler::NormalsActorItem::createNormalLines()
     points->SetData(vtkSmartPointer<vtkFloatArray>::New());
 
   auto* data = dynamic_cast<vtkFloatArray*>(points->GetData());
+  if (!data)
+    return;
   data->SetNumberOfComponents(3);
 
   if (cloud->is_dense) {

apps/modeler/src/parameter.cpp

@@ -80,6 +80,8 @@ void
 pcl::modeler::IntParameter::setEditorData(QWidget* editor)
 {
   auto* spinBox = dynamic_cast<QSpinBox*>(editor);
+  if (!spinBox)
+    return;
   spinBox->setAlignment(Qt::AlignHCenter);
 
   int value = int(*this);
@@ -91,6 +93,8 @@ void
 pcl::modeler::IntParameter::getEditorData(QWidget* editor)
 {
   auto* spinBox = dynamic_cast<QSpinBox*>(editor);
+  if (!spinBox)
+    return;
   int value = spinBox->text().toInt();
   current_value_ = value;
 }
@@ -126,6 +130,8 @@ void
 pcl::modeler::BoolParameter::setEditorData(QWidget* editor)
 {
   auto* checkBox = dynamic_cast<QCheckBox*>(editor);
+  if (!checkBox)
+    return;
 
   bool value = bool(*this);
   checkBox->setCheckState(value ? (Qt::Checked) : (Qt::Unchecked));
@@ -136,6 +142,8 @@ void
 pcl::modeler::BoolParameter::getEditorData(QWidget* editor)
 {
   auto* checkBox = dynamic_cast<QCheckBox*>(editor);
+  if (!checkBox)
+    return;
   bool value = (checkBox->checkState() == Qt::Checked);
   current_value_ = value;
 }
@@ -175,6 +183,8 @@ void
 pcl::modeler::DoubleParameter::setEditorData(QWidget* editor)
 {
   auto* spinBox = dynamic_cast<QDoubleSpinBox*>(editor);
+  if (!spinBox)
+    return;
   spinBox->setAlignment(Qt::AlignHCenter);
 
   double value = double(*this);
@@ -186,6 +196,8 @@ void
 pcl::modeler::DoubleParameter::getEditorData(QWidget* editor)
 {
   auto* spinBox = dynamic_cast<QDoubleSpinBox*>(editor);
+  if (!spinBox)
+    return;
   double value = spinBox->text().toDouble();
   current_value_ = value;
 }
@@ -221,6 +233,8 @@ void
 pcl::modeler::ColorParameter::setEditorData(QWidget* editor)
 {
   auto* color_dialog = dynamic_cast<QColorDialog*>(editor);
+  if (!color_dialog)
+    return;
 
   QColor value = QColor(*this);
   color_dialog->setCurrentColor(value);
@@ -231,6 +245,8 @@ void
 pcl::modeler::ColorParameter::getEditorData(QWidget* editor)
 {
   auto* color_dialog = dynamic_cast<QColorDialog*>(editor);
+  if (!color_dialog)
+    return;
 
   QColor value = color_dialog->currentColor();
   current_value_ = value;

apps/modeler/src/points_actor_item.cpp

@@ -78,8 +78,10 @@ pcl::modeler::PointsActorItem::initImpl()
   mapper->InterpolateScalarsBeforeMappingOn();
   mapper->ScalarVisibilityOn();
 
-  vtkSmartPointer<vtkLODActor> actor =
-      vtkSmartPointer<vtkLODActor>(dynamic_cast<vtkLODActor*>(actor_.GetPointer()));
+  auto* actor_ptr = dynamic_cast<vtkLODActor*>(actor_.GetPointer());
+  if (!actor_ptr)
+    return;
+  vtkSmartPointer<vtkLODActor> actor = vtkSmartPointer<vtkLODActor>(actor_ptr);
   actor->SetMapper(mapper);
 
   actor->SetNumberOfCloudPoints(

apps/modeler/src/surface_actor_item.cpp

@@ -75,8 +75,10 @@ pcl::modeler::SurfaceActorItem::initImpl()
   mapper->InterpolateScalarsBeforeMappingOn();
   mapper->ScalarVisibilityOn();
 
-  vtkSmartPointer<vtkLODActor> actor =
-      vtkSmartPointer<vtkLODActor>(dynamic_cast<vtkLODActor*>(actor_.GetPointer()));
+  auto* actor_ptr = dynamic_cast<vtkLODActor*>(actor_.GetPointer());
+  if (!actor_ptr)
+    return;
+  vtkSmartPointer<vtkLODActor> actor = vtkSmartPointer<vtkLODActor>(actor_ptr);
   actor->SetMapper(mapper);
 
   actor->SetNumberOfCloudPoints(