Conversation
don't even
combobox was not working correctly
fix for code scanning alert no. 12 Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/app/_home/`$school/$year/$id/-location-select.tsx:
- Around line 94-108: The Tabs component lowercases tokens for selection, but
LocationsTabs currently lowercases the value passed to onChange which loses
original casing/accents; update LocationsTabs (function LocationsTabs, props
value/onChange/locations and the Tabs onValueChange handler) to translate the
emitted lowercased token back to the original location string before calling
onChange by finding the matching entry in the locations array (compare
location.toLowerCase()), keep using value.toLowerCase() and
location.toLowerCase() for Tab keys/values so selection works, but always call
onChange with the raw original location string.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@biome.jsonc`:
- Around line 2-3: Update the Biome config: bump the schema version string in
"$schema" from 2.3.8 to 2.3.11 and remove the redundant exclusion patterns from
the "formatter.includes" array (the duplicated patterns like node_modules, dist,
.vite, .vscode, .idea, .DS_Store, log files, etc.) because "vcs.useIgnoreFile":
true already makes Biome respect .gitignore; keep "vcs" and "useIgnoreFile"
intact and only change the schema version and prune the duplicated entries under
"formatter.includes".
🧹 Nitpick comments (1)
biome.jsonc (1)
14-55: Formatter settings look good; consider simplifying exclusions.The formatting options (2-space indent, LF line endings, 80-char width) are standard and appropriate. The
.vscode/extensions.jsonwhitelist after excluding.vscode/*is a nice touch.As noted above, many exclusions (lines 40-53:
node_modules,dist, logs, etc.) likely overlap with.gitignoreand could be removed givenvcs.useIgnoreFile: true.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Changelog:
(see https://github.com/PoliNetworkOrg/rankings-backend-go and https://github.com/PoliNetworkOrg/rankings-data)