-
Notifications
You must be signed in to change notification settings - Fork 0
feat: implement Ban All #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Useful for long-term menus, like BanAll voting
d1dacbf to
190426d
Compare
* feat: module coordinator * chore: folder structure * fix: don't know how variables work * fix: websocket lifecycle * feat: BanAll message update on progress * feat: unicode progress bar!!!! * fix(group-mgmt): join+admin correct handling * feat: ban-all --------- Co-authored-by: Lorenzo Corallo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a comprehensive "Ban All" voting system that allows Direttivo members to vote on banning/unbanning users across all network groups. The implementation includes voting utilities, queue-based job processing, menu interactions, and comprehensive test coverage.
- Implements voting logic with presidential tie-breaking rules specific to Direttivo governance
- Adds interactive voting menus with real-time progress tracking during ban execution
- Integrates job queue system using BullMQ for scalable ban/unban operations across multiple groups
Reviewed Changes
Copilot reviewed 33 out of 36 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/vote.test.ts |
Comprehensive test suite for voting outcome calculations |
tests/throttle.test.ts |
Test coverage for throttle utility function |
src/utils/vote.ts |
Core voting logic implementing Direttivo governance rules |
src/utils/throttle.ts |
Utility for rate-limiting function calls |
src/utils/progress.ts |
Progress bar visualization utilities |
src/utils/wait.ts |
Async utilities including new Awaiter class |
src/modules/tg-logger/ban-all.ts |
Ban All voting menu and UI logic |
src/modules/moderation/ban-all.ts |
Queue-based job processing for ban operations |
src/commands/banall.ts |
CLI commands for initiating ban/unban requests |
src/lib/modules/index.ts |
Module coordination system for shared dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 34 out of 37 changed files in this pull request and generated 5 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 34 out of 37 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 34 out of 37 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 34 out of 37 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 34 out of 37 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 35 out of 38 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
src/utils/vote.ts:1
- There's a typo: 'absteined' should be 'abstained'.
import type { User } from "grammy/types"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Finally, Copilot ended its monologue |
|
LGTM 👍 |
Uh oh!
There was an error while loading. Please reload this page.