Remove improperly netsted metadata JSON #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesmit
approved these changes
Dec 23, 2024
Collaborator
mikesmit
left a comment
mikesmit
left a comment
There was a problem hiding this comment.
Agree this fixes the problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PolicyEngine/issues#30
This issue was created by an improper assumption in #2038 whereby the metadata endpoint was improperly documented, and changes based upon the typing documentation created a doubly nested output that does not fit our intended schema. This reverts that, and a future issue will be opened to properly configure this so that the metadata route and service are configured as expected.