Removed seed method from PolicyEngineDatabase class #2079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for this @SakshiKekre. Tests failed the first time, so I'm re-running to see what might have happened. If they fail again, I'll leave some comments on how to proceed. |
Collaborator
|
@SakshiKekre We've come across this issue once or twice before, and if I remember correctly, updating your local API version may help here. Would you mind rebasing off of master, then force-pushing and rerunning tests? |
Collaborator
|
@SakshiKekre I stand corrected, this was a token issue, so I'll re-run and see if this passes |
anth-volk
approved these changes
Jan 4, 2025
Collaborator
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
Thank you very much for this @SakshiKekre! Merging now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1362
What: Removed the definition for seed method from PolicyEngineDatabase class as well as any calls to the method from within the class.
Why: Test code that is no longer required.