feat: Enable Modal simulation API by default #3068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default value of USE_MODAL_SIMULATION_API from "false" to "true", making Modal the default backend for economy simulations. The GCP Workflows backend can still be used by setting USE_MODAL_SIMULATION_API=false. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Update test to expect Modal API when env var is not set (default changed) - Update GCP credentials test to explicitly set USE_MODAL_SIMULATION_API=false - Run black formatter on entire package 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3068 +/- ##
==========================================
- Coverage 71.05% 70.73% -0.33%
==========================================
Files 57 57
Lines 2436 2436
Branches 339 339
==========================================
- Hits 1731 1723 -8
- Misses 644 653 +9
+ Partials 61 60 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
USE_MODAL_SIMULATION_APIfrom"false"to"true"USE_MODAL_SIMULATION_API=falseContext
This PR "flips the switch" to enable the Modal simulation API by default, following the infrastructure work in PR #3065.
Related: #3064
Test plan
false🤖 Generated with Claude Code