Skip to content

Point reproduce in Python segments to HuggingFace URLs#2316

Merged
anth-volk merged 8 commits intomasterfrom
nikhilwoodruff/issue2315
Feb 4, 2025
Merged

Point reproduce in Python segments to HuggingFace URLs#2316
anth-volk merged 8 commits intomasterfrom
nikhilwoodruff/issue2315

Conversation

@nikhilwoodruff
Copy link
Collaborator

Fixes #2315

Description

Point dataset strings to URLs instead

Changes

As above.

Screenshots

image ## Tests

No tests added.

@vercel
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
policyengine-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 4:17pm

Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nikhilwoodruff, thanks for this quick turnaround. My main thought is in my comment below, but TL;DR, would it be more logical (and equally as fast) to solve this in us-data? Looking forward to your thoughts.

@anth-volk anth-volk self-requested a review January 30, 2025 23:26
Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on conversation with @nikhilwoodruff, I think this is good to go, as we will re-enable simpler dataset loading with the inclusion of policyengine.py within the API. @nikhilwoodruff if you could lint this, it should be good to merge!

@anth-volk
Copy link
Collaborator

@nikhilwoodruff I've taken the liberty of linting in order to get this merged.

@anth-volk anth-volk merged commit 46e81d2 into master Feb 4, 2025
3 checks passed
@anth-volk anth-volk deleted the nikhilwoodruff/issue2315 branch February 4, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Point reproduce in Python segments to HuggingFace URLs

4 participants